Fix incorrect error message on invalid secret

markspolakovs · web-flow · commit f86c67921163 · 2021-02-26T10:56:34.000Z
If a token with an invalid secret key is passed, the error returned will be `The iss do not match with this server` when the `iss` field is set correctly. This PR fixes that.
diff --git a/src/Auth.php b/src/Auth.php
@@ -571,7 +571,7 @@ public static function validate_token( $token = null, $refresh = false ) {
 		try {
 			$token = ! empty( $token ) ? JWT::decode( $token, $secret, [ 'HS256' ] ) : null;
 		} catch ( \Exception $exception ) {
-			$token =  new \WP_Error( 'invalid-secret-key', $exception->getMessage() );
+			return new \WP_Error( 'invalid-secret-key', $exception->getMessage() );
 		}
 
 		/**

Original file line number	Diff line number	Diff line change
`@@ -571,7 +571,7 @@ public static function validate_token( $token = null, $refresh = false ) {`
`571`	`571`	`try {`
`572`	`572`	`$token = ! empty( $token ) ? JWT::decode( $token, $secret, [ 'HS256' ] ) : null;`
`573`	`573`	`} catch ( \Exception $exception ) {`
`574`		`- $token = new \WP_Error( 'invalid-secret-key', $exception->getMessage() );`
	`574`	`+ return new \WP_Error( 'invalid-secret-key', $exception->getMessage() );`
`575`	`575`	`}`
`576`	`576`
`577`	`577`	`/**`