fix: Connections need to connect to Types that implement the Node interface (#675)

* - implement Node on different Types

* - update class-customers to return arrays for edges and nodes
- move id resolver from product-attribute interface to the specific types

* - return empty arrays for edges/nodes for coupon connections
- update test to check for falsy vs null

* - remove manual registration of the `Product` Interface
- register the fields to the Product Interface

* - fix code style

* - fix code style

* - no longer pass type registry to Product::register_interface()

* -  use post type registry to register the Product type as an Interface

* WPGraphQL v1.13.x support added.

* WPGraphQL v1.13.x support added.

* fix: filter corrected.

* fix: Needed code restored

* fix: Needed code restored

* parent field no longer overwritten

* chore: WPCS compliance met.

Co-authored-by: Geoff Taylor <[email protected]>

Author: jasonbahl

bin/_env.sh

@@ -8,6 +8,7 @@
 
 namespace WPGraphQL\WooCommerce;
 
+use GraphQL\Error\UserError;
 use WPGraphQL\WooCommerce\Data\Loader\WC_Customer_Loader;
 use WPGraphQL\WooCommerce\Data\Loader\WC_CPT_Loader;
 use WPGraphQL\WooCommerce\Data\Loader\WC_Db_Loader;
@@ -134,11 +135,27 @@ public static function add_filters() {
 	 */
 	public static function register_post_types( $args, $post_type ) {
 		if ( 'product' === $post_type ) {
-			$args['show_in_graphql']            = true;
-			$args['graphql_single_name']        = 'Product';
-			$args['graphql_plural_name']        = 'Products';
-			$args['skip_graphql_type_registry'] = true;
-		}
+			$args['show_in_graphql']                  = true;
+			$args['graphql_single_name']              = 'Product';
+			$args['graphql_plural_name']              = 'Products';
+			$args['graphql_kind']                     = 'interface';
+			$args['graphql_register_root_field']      = false;
+			$args['graphql_register_root_connection'] = false;
+			$args['graphql_resolve_type']             = static function( $value ) {
+				$type_registry  = \WPGraphQL::get_type_registry();
+				$possible_types = WP_GraphQL_WooCommerce::get_enabled_product_types();
+				if ( isset( $possible_types[ $value->type ] ) ) {
+					return $type_registry->get_type( $possible_types[ $value->type ] );
+				}
+				throw new UserError(
+					sprintf(
+					/* translators: %s: Product type */
+						__( 'The "%s" product type is not supported by the core WPGraphQL WooCommerce (WooGraphQL) schema.', 'wp-graphql-woocommerce' ),
+						$value->type
+					)
+				);
+			};
+		}//end if
 		if ( 'product_variation' === $post_type ) {
 			$args['show_in_graphql']            = true;
 			$args['graphql_single_name']        = 'ProductVariation';

bin/_lib.sh

@@ -59,7 +59,7 @@ public function init( \WPGraphQL\Registry\TypeRegistry $type_registry ) {
 		Type\WPInputObject\Orderby_Inputs::register();
 
 		// Interfaces.
-		Type\WPInterface\Product::register_interface( $type_registry );
+		Type\WPInterface\Product::register_interface();
 		Type\WPInterface\Attribute::register_interface( $type_registry );
 		Type\WPInterface\Product_Attribute::register_interface( $type_registry );
 		Type\WPInterface\Cart_Error::register_interface( $type_registry );

bin/codecept

@@ -45,7 +45,10 @@ public static function get_connection_config( $args = [] ): array {
 					$resolver = new PostObjectConnectionResolver( $source, $args, $context, $info, 'shop_coupon' );
 
 					if ( ! self::should_execute() ) {
-						return [];
+						return [
+							'edges' => [],
+							'nodes' => [],
+						];
 					}
 
 					return $resolver->get_connection();