fix: WP User core field support fixed in updateCustomer mutation (#789)

* devops: CustomerMutationsTest refactored heavily

* fix: `updateCustomer` mutation patched

Author: kidunot89

bin/_lib.sh

@@ -71,7 +71,8 @@ install_local_test_library() {
 		codeception/module-rest:* \
 		codeception/util-universalframework:^1.0  \
 		wp-graphql/wp-graphql-testcase:^2.3 \
-		stripe/stripe-php
+		stripe/stripe-php \
+		fakerphp/faker
 
 }
 
@@ -102,7 +103,8 @@ remove_local_test_library() {
 		codeception/module-rest \
 		codeception/util-universalframework \
 		lucatume/wp-browser \
-		stripe/stripe-php
+		stripe/stripe-php \
+		fakerphp/faker
 }
 
 cleanup_composer_file() {

composer.lock

@@ -96,6 +96,7 @@ public static function empty_shipping() {
 			'state'      => '',
 			'postcode'   => '',
 			'country'    => '',
+			'phone'      => '',
 		];
 	}
 
@@ -107,10 +108,7 @@ public static function empty_shipping() {
 	public static function empty_billing() {
 		return array_merge(
 			self::empty_shipping(),
-			[
-				'email' => '',
-				'phone' => '',
-			]
+			[ 'email' => '' ]
 		);
 	}
 

includes/data/mutation/class-customer-mutation.php

@@ -93,13 +93,17 @@ public static function get_output_fields() {
 	 */
 	public static function mutate_and_get_payload() {
 		return static function ( $input, AppContext $context, ResolveInfo $info ) {
-			$session_only = empty( $input['id'] );
+			$session_only = empty( $input['id'] ) && ! is_user_logged_in();
 			$payload      = null;
 
 			if ( ! $session_only ) {
 				// Get closure from "UserRegister::mutate_and_get_payload".
 				$update_user = UserUpdate::mutate_and_get_payload();
 
+				if ( ! isset( $input['id'] ) ) {
+					$input['id'] = get_current_user_id();
+				}
+
 				// Update customer with core UserUpdate closure.
 				$payload = $update_user( $input, $context, $info );
 

includes/mutation/class-customer-update.php

@@ -8,7 +8,7 @@
 
 namespace Tests\WPGraphQL\WooCommerce\Factory;
 
-use Tests\WPGraphQL\WooCommerce\Utils\Dummy;
+use Faker\Factory;
 
 /**
  * Customer factory class for testing.
@@ -18,7 +18,7 @@ public function __construct( $factory = null ) {
 		parent::__construct( $factory );
 
 		$this->default_generation_definitions = [];
-		$this->dummy                          = Dummy::instance();
+		$this->dummy                          = Factory::create();
 	}
 
 	public function create_object( $args ) {
@@ -29,16 +29,16 @@ public function create_object( $args ) {
 		$customer = new \WC_Customer();
 
 		// Create customer details
-		$username   = $this->dummy->username();
-		$first_name = $this->dummy->firstname();
-		$last_name  = $this->dummy->lastname();
-		$street     = $this->dummy->street();
+		$username   = $this->dummy->userName();
+		$first_name = $this->dummy->firstName();
+		$last_name  = $this->dummy->lastName();
+		$street     = $this->dummy->streetAddress();
 		$city       = $this->dummy->city();
 		$state      = $this->dummy->state();
-		$postcode   = $this->dummy->zipcode();
+		$postcode   = $this->dummy->postcode();
 		$country    = 'US';
 		$email      = $this->dummy->email();
-		$phone      = $this->dummy->telephone();
+		$phone      = $this->dummy->phoneNumber();
 
 		$args = array_merge(
 			[
@@ -66,6 +66,7 @@ public function create_object( $args ) {
 		$customer->set_shipping_state( ! empty( $args['shipping']['state'] ) ? $args['shipping']['state'] : $state );
 		$customer->set_shipping_postcode( ! empty( $args['shipping']['postcode'] ) ? $args['shipping']['postcode'] : $postcode );
 		$customer->set_shipping_country( ! empty( $args['shipping']['country'] ) ? $args['shipping']['country'] : $country );
+		$customer->set_shipping_phone( ! empty( $args['shipping']['phone'] ) ? $args['shipping']['phone'] : $phone );
 
 		// Set data.
 		$customer->set_props(