fix: "Product" interface applied to all sub Product interfaces for more optimal schema shape

Author: kidunot89

composer.json

@@ -40,8 +40,7 @@
         "allow-plugins": {
             "johnpbloch/wordpress-core-installer": true,
             "dealerdirect/phpcodesniffer-composer-installer": true,
-            "phpstan/extension-installer": true,
-            "composer/installers": true
+            "phpstan/extension-installer": true
         }
     },
     "autoload": {

composer.lock

@@ -25,7 +25,7 @@ public static function register_interface(): void {
 			'DownloadableProduct',
 			[
 				'description' => __( 'A downloadable product.', 'wp-graphql-woocommerce' ),
-				'interfaces'  => [ 'Node' ],
+				'interfaces'  => [ 'Node', 'Product' ],
 				'fields'      => self::get_fields(),
 				'resolveType' => [ Core::class, 'resolve_product_type' ],
 			]
@@ -47,10 +47,6 @@ public static function get_fields() {
 				'type'        => [ 'non_null' => 'Int' ],
 				'description' => __( 'Product or variation ID', 'wp-graphql-woocommerce' ),
 			],
-			'virtual'        => [
-				'type'        => 'Boolean',
-				'description' => __( 'Is product virtual?', 'wp-graphql-woocommerce' ),
-			],
 			'downloadExpiry' => [
 				'type'        => 'Int',
 				'description' => __( 'Download expiry', 'wp-graphql-woocommerce' ),

includes/type/interface/class-downloadable-product.php

@@ -25,7 +25,7 @@ public static function register_interface(): void {
 			'InventoriedProduct',
 			[
 				'description' => __( 'A product with stock information.', 'wp-graphql-woocommerce' ),
-				'interfaces'  => [ 'Node' ],
+				'interfaces'  => [ 'Node', 'Product' ],
 				'fields'      => self::get_fields(),
 				'resolveType' => [ Core::class, 'resolve_product_type' ],
 			]

includes/type/interface/class-inventoried-product.php

@@ -26,7 +26,7 @@ public static function register_interface(): void {
 			'ProductUnion',
 			[
 				'description' => __( 'Union between the product and product variation types', 'wp-graphql-woocommerce' ),
-				'interfaces'  => [ 'Node' ],
+				'interfaces'  => [ 'Node', 'Product' ],
 				'fields'      => self::get_fields(),
 				'resolveType' => [ Core::class, 'resolve_product_type' ],
 			]

includes/type/interface/class-product-union.php

@@ -28,7 +28,7 @@ public static function register_interface(): void {
 			'ProductWithAttributes',
 			[
 				'description' => __( 'Products with default attributes.', 'wp-graphql-woocommerce' ),
-				'interfaces'  => [ 'Node' ],
+				'interfaces'  => [ 'Node', 'Product' ],
 				'fields'      => self::get_fields(),
 				'connections' => self::get_connections(),
 				'resolveType' => [ Core::class, 'resolve_product_type' ],

includes/type/interface/class-product-with-attributes.php

@@ -25,7 +25,7 @@ public static function register_interface(): void {
 			'ProductWithDimensions',
 			[
 				'description' => __( 'A physical product.', 'wp-graphql-woocommerce' ),
-				'interfaces'  => [ 'Node' ],
+				'interfaces'  => [ 'Node', 'Product' ],
 				'fields'      => self::get_fields(),
 				'resolveType' => [ Core::class, 'resolve_product_type' ],
 			]

includes/type/interface/class-product-with-dimensions.php

@@ -25,7 +25,7 @@ public static function register_interface(): void {
 			'ProductWithPricing',
 			[
 				'description' => __( 'Products with pricing.', 'wp-graphql-woocommerce' ),
-				'interfaces'  => [ 'Node' ],
+				'interfaces'  => [ 'Node', 'Product' ],
 				'fields'      => self::get_fields(),
 				'resolveType' => [ Core::class, 'resolve_product_type' ],
 			]

includes/type/interface/class-product-with-pricing.php

@@ -29,7 +29,7 @@ public static function register_interface(): void {
 			'ProductWithVariations',
 			[
 				'description' => __( 'A product with variations.', 'wp-graphql-woocommerce' ),
-				'interfaces'  => [ 'Node' ],
+				'interfaces'  => [ 'Node', 'Product' ],
 				'fields'      => self::get_fields(),
 				'connections' => self::get_connections(),
 				'resolveType' => [ Core::class, 'resolve_product_type' ],

includes/type/interface/class-product-with-variations.php

@@ -201,6 +201,10 @@ public static function get_fields() {
 				'type'        => 'Boolean',
 				'description' => __( 'Can product be purchased?', 'wp-graphql-woocommerce' ),
 			],
+			'virtual'           => [
+				'type'        => 'Boolean',
+				'description' => __( 'Is product virtual?', 'wp-graphql-woocommerce' ),
+			],
 			'metaData'          => \WPGraphQL\WooCommerce\Type\WPObject\Meta_Data_Type::get_metadata_field_definition(),
 		];
 	}