CartQueriesTest updated.

Author: kidunot89

.travis.yml

@@ -17,7 +17,7 @@ branches:
     - master
     - release-v0.1.2
     - release-v0.2.2
-    - release-v0.3.1
+    - release-v0.3.3
 
 cache:
   apt: true

includes/connection/class-cart-items.php

@@ -84,7 +84,7 @@ public static function get_connection_config( $args = array() ) {
 	 */
 	public static function get_connection_args() {
 		return array(
-			'needShipping' => array(
+			'needsShipping' => array(
 				'type'        => 'Boolean',
 				'description' => __( 'Limit results to cart items that require shipping', 'wp-graphql-woocommerce' ),
 			),

includes/data/connection/class-cart-item-connection-resolver.php

@@ -30,23 +30,37 @@ public function should_execute() {
 	}
 
 	/**
-	 * Creates query arguments array
+	 * Creates cart item filters.
+	 *
+	 * @return array
 	 */
 	public function get_query_args() {
 		$query_args = array();
 		if ( ! empty( $this->args['where'] ) ) {
 			$where_args = $this->args['where'];
-			if ( ! empty( $where_args['needShipping'] ) ) {
+			if ( isset( $where_args['needsShipping'] ) ) {
+				$needs_shipping          = $where_args['needsShipping'];
 				$query_args['filters']   = array();
-				$query_args['filters'][] = function( $cart_item ) {
+				$query_args['filters'][] = function( $cart_item ) use ( $needs_shipping ) {
 					$product = \WC()->product_factory->get_product( $cart_item['product_id'] );
 					if ( $product ) {
-						return $product->needs_shipping();
+						return $needs_shipping === (bool) $product->needs_shipping();
 					}
 				};
 			}
 		}
 
+		/**
+		 * Filter the $query_args to allow folks to customize queries programmatically.
+		 *
+		 * @param array       $query_args The args that will be passed to the WP_Query.
+		 * @param mixed       $source     The source that's passed down the GraphQL queries.
+		 * @param array       $args       The inputArgs on the field.
+		 * @param AppContext  $context    The AppContext passed down the GraphQL tree.
+		 * @param ResolveInfo $info       The ResolveInfo passed down the GraphQL tree.
+		 */
+		$query_args = apply_filters( 'graphql_cart_item_connection_query_args', $query_args, $this->source, $this->args, $this->context, $this->info );
+
 		return $query_args;
 	}
 

tests/wpunit/CartQueriesTest.php

@@ -117,7 +117,7 @@ public function testCartItemQuery() {
 
 	public function testCartItemConnection() {
 		$cart = WC()->cart;
-		$cart->add_to_cart( $this->product_helper->create_simple(), 2 );
+		$cart->add_to_cart( $this->product_helper->create_simple( array( 'virtual' => true ) ), 2 );
 		$cart->add_to_cart( $this->product_helper->create_simple(), 1 );
 		$cart->add_to_cart( $this->product_helper->create_simple(), 10 );
 
@@ -132,9 +132,9 @@ public function testCartItemConnection() {
 		$cart->apply_coupon( $code );
 
 		$query = '
-			query {
+			query($needsShipping: Boolean) {
 				cart {
-					contents {
+					contents (where: {needsShipping: $needsShipping}) {
 						nodes {
 							key
 						}
@@ -161,6 +161,76 @@ public function testCartItemConnection() {
 		codecept_debug( $actual );
 
 		$this->assertEquals( $expected, $actual );
+
+		/**
+		 * Assertion Two
+		 * 
+		 * Tests "needsShipping" parameter.
+		 */
+		$variables = array( 'needsShipping' => true );
+		$actual    = graphql(
+			array(
+				'query'     => $query,
+				'variables' => $variables,
+			)
+		);
+		$expected  = array(
+			'data' => array(
+				'cart' => array(
+					'contents' => array(
+						'nodes' => $this->helper->print_nodes(
+							array(
+								'filter' => function( $key ) {
+									$item = WC()->cart->get_cart_item( $key );
+									$product = WC()->product_factory->get_product( $item['product_id'] );
+									return $product->needs_shipping();
+								}
+							)
+						),
+					),
+				),
+			),
+		);
+
+		// use --debug flag to view.
+		codecept_debug( $actual );
+
+		$this->assertEquals( $expected, $actual );
+
+		/**
+		 * Assertion Three
+		 * 
+		 * Tests "needsShipping" parameter reversed.
+		 */
+		$variables = array( 'needsShipping' => false );
+		$actual    = graphql(
+			array(
+				'query'     => $query,
+				'variables' => $variables,
+			)
+		);
+		$expected  = array(
+			'data' => array(
+				'cart' => array(
+					'contents' => array(
+						'nodes' => $this->helper->print_nodes(
+							array(
+								'filter' => function( $key ) {
+									$item = WC()->cart->get_cart_item( $key );
+									$product = WC()->product_factory->get_product( $item['product_id'] );
+									return ! $product->needs_shipping();
+								}
+							)
+						),
+					),
+				),
+			),
+		);
+
+		// use --debug flag to view.
+		codecept_debug( $actual );
+
+		$this->assertEquals( $expected, $actual );
 	}
 
 	public function testCartFeeQuery() {