Merge pull request #381 from kidunot89/feature/register-customer-without-username

Make the username field optional in registerCustomer mutation

Author: kidunot89

includes/mutation/class-customer-register.php

@@ -43,7 +43,7 @@ public static function register_mutation() {
 	 * @return array
 	 */
 	public static function get_input_fields() {
-		return array_merge(
+		$result = array_merge(
 			UserRegister::get_input_fields(),
 			array(
 				'billing'               => array(
@@ -59,7 +59,12 @@ public static function get_input_fields() {
 					'description' => __( 'Customer shipping is identical to billing address', 'wp-graphql-woocommerce' ),
 				),
 			)
-		);
+    	);
+
+		// Make the username field optional.
+    	$result['username']['type'] = 'String';
+
+    	return $result;
 	}
 
 	/**
@@ -93,9 +98,6 @@ public static function get_output_fields() {
 	public static function mutate_and_get_payload() {
 		return function( $input, AppContext $context, ResolveInfo $info ) {
 			// Validate input.
-			if ( empty( $input['username'] ) ) {
-				throw new UserError( __( 'Please enter a valid account username.', 'wp-graphql-woocommerce' ) );
-			}
 			if ( empty( $input['email'] ) ) {
 				throw new UserError( __( 'Please provide a valid email address.', 'wp-graphql-woocommerce' ) );
 			}
@@ -114,10 +116,10 @@ public static function mutate_and_get_payload() {
 			$user_args = UserMutation::prepare_user_object( $input, 'registerCustomer' );
 
 			// Create the user using native WooCommerce function.
-			$user_id = wc_create_new_customer(
+			$user_id = \wc_create_new_customer(
 				$user_args['user_email'],
-				$user_args['user_login'],
-				isset($user_args['user_pass']) ? $user_args['user_pass'] : '',
+				isset( $user_args['user_login'] ) ? $user_args['user_login'] : '',
+				isset( $user_args['user_pass'] ) ? $user_args['user_pass'] : '',
 				$user_args
 			);
 

tests/wpunit/CustomerMutationsTest.php

@@ -201,7 +201,6 @@ private function updateCustomer( $input ) {
 		return $actual;
 	}
 
-	// tests
 	public function testRegisterMutationWithoutCustomerInfo() {
 		/**
 		 * Assertion One
@@ -518,4 +517,50 @@ public function testUpdateMutationWithShippingSameAsBilling() {
 
 		$this->assertEquals( $expected, $actual );
 	}
+
+	public function testRegisterMutationWithoutAnyInfo() {
+		/**
+		 * Assertion One
+		 *
+		 * Tests mutation without a providing an username and password.
+		 */
+		$actual = $this->registerCustomer(
+			array(
+				'clientMutationId' => 'someId',
+				'email'            => $this->email,
+				'firstName'        => $this->first_name,
+				'lastName'         => $this->last_name,
+			)
+		);
+
+		// use --debug flag to view.
+		codecept_debug( $actual );
+
+		$user = get_user_by( 'email', '[email protected]' );
+		$this->assertTrue( is_a( $user, WP_User::class ) );
+
+		$expected = array(
+			'data' => array(
+				'registerCustomer' => array(
+					'clientMutationId' => 'someId',
+					'authToken'        => \WPGraphQL\JWT_Authentication\Auth::get_token( $user ),
+					'refreshToken'     => \WPGraphQL\JWT_Authentication\Auth::get_refresh_token( $user ),
+					'customer'         => array(
+						'databaseId' => $user->ID,
+						'email'      => $this->email,
+						'username'   => $user->user_login,
+						'firstName'  => $this->first_name,
+						'lastName'   => $this->last_name,
+						'billing'    => $this->empty_billing(),
+						'shipping'   => $this->empty_shipping(),
+					),
+					'viewer'           => array(
+						'userId' => $user->ID,
+					)
+				),
+			),
+		);
+
+		$this->assertEquals( $expected, $actual );
+	}
 }