fix: Meta data type error fixed. (#728)

* fix: Meta data type error fixed.

* devops: CouponQueriesTest updated.

* chore: WPCS compliance met

Author: kidunot89

includes/type/object/class-meta-data-type.php

@@ -44,7 +44,15 @@ public static function register() {
 						'type'        => 'String',
 						'description' => __( 'Meta value.', 'wp-graphql-woocommerce' ),
 						'resolve'     => function ( $source ) {
-							return ! empty( $source->value ) ? (string) $source->value : null;
+							if ( empty( $source->value ) ) {
+								return null;
+							}
+
+							if ( is_array( $source->value ) || is_object( $source->value ) ) {
+								return wp_json_encode( $source->value );
+							}
+
+							return (string) $source->value;
 						},
 					],
 				],

includes/type/object/class-root-query.php

@@ -115,6 +115,13 @@ public static function register_fields() {
 								break;
 						}
 
+						// Check if user authorized to view coupon.
+						$post_type     = get_post_type_object( 'shop_coupon' );
+						$is_authorized = current_user_can( $post_type->cap->edit_others_posts );
+						if ( ! $is_authorized ) {
+							return null;
+						}
+
 						if ( empty( $coupon_id ) ) {
 							/* translators: %1$s: ID type, %2$s: ID value */
 							throw new UserError( sprintf( __( 'No coupon ID was found corresponding to the %1$s: %2$s', 'wp-graphql-woocommerce' ), $id_type, $id ) );
@@ -212,7 +219,7 @@ public static function register_fields() {
 						// Check if user authorized to view order.
 						$post_type     = get_post_type_object( 'shop_order' );
 						$is_authorized = current_user_can( $post_type->cap->edit_others_posts );
-						if ( get_current_user_id() ) {
+						if ( ! $is_authorized && get_current_user_id() ) {
 							$orders = wc_get_orders(
 								[
 									'type'          => 'shop_order',

tests/wpunit/CouponQueriesTest.php

@@ -120,13 +120,24 @@ public function testCouponQuery() {
 
 		/**
 		 * Assertion One
+		 *
+		 * Confirm customer's can't query coupons by ID.
 		 */
 		$this->loginAsCustomer();
 		$variables = [ 'id' => $this->toRelayId( 'shop_coupon', $coupon_id ) ];
 		$response  = $this->graphql( compact( 'query', 'variables' ) );
-		$expected  = $this->expectedCouponData( $coupon_id );
+		$expected  = [ $this->expectedField( 'coupon', self::IS_NULL ) ];
 
 		$this->assertQuerySuccessful( $response, $expected );
+
+		/**
+		 * Assertion Two
+		 *
+		 * Confirm shop managers can query coupons by ID.
+		 */
+		$this->loginAsShopManager();
+		$response = $this->graphql( compact( 'query', 'variables' ) );
+		$this->assertQuerySuccessful( $response, $this->expectedCouponData( $coupon_id ) );
 	}
 
 	public function testCouponQueryAndIds() {
@@ -147,7 +158,7 @@ public function testCouponQueryAndIds() {
 		 *
 		 * Testing "ID" ID type.
 		 */
-		$this->loginAsCustomer();
+		$this->loginAsShopManager();
 		$variables = [
 			'id'     => $relay_id,
 			'idType' => 'ID',