- update resolvers that use set_query_arg to pass certain args as $args _before_ the resolver is instantiated, and then use set_query_args to override some args after the resolver is instantiated. This allows for args such as in or include to be used by the ConnectionResolver in determining things like pagination and cursor slicing

Author: jasonbahl

src/FieldType/Gallery.php

@@ -58,11 +58,14 @@ static function ( $id ) {
 									$value
 								) : $value;
 
+								if ( empty( $value ) ) {
+									return null;
+								}
+
+								$args['where']['in'] = $value;
 								$resolver = new PostObjectConnectionResolver( $root, $args, $context, $info, 'attachment' );
-								return $resolver
-								->set_query_arg( 'post__in', $value )
-								->set_query_arg( 'orderby', 'post__in' )
-								->get_connection();
+								$resolver->set_query_arg( 'post_status', 'any' );
+								return $resolver->get_connection();
 							},
 						]
 					);

src/FieldType/Relationship.php

@@ -95,20 +95,20 @@ static function ( $id ) {
 					)
 				);
 
-				$resolver = new PostObjectConnectionResolver( $root, $args, $context, $info, 'any' );
+				if ( empty( $ids ) ) {
+					return null;
+				}
 
+				// override the args to filter by a specific set of IDs
+				$args['where']['in']     = $ids;
+				$resolver = new PostObjectConnectionResolver( $root, $args, $context, $info, 'any' );
 
 				if ( $is_one_to_one ) {
 					$resolver = $resolver->one_to_one();
 				}
 
-				return $resolver
-					// the relationship field doesn't require related things to be published
-					// so we set the status to "any"
-					->set_query_arg( 'post_status', 'any' )
-					->set_query_arg( 'post__in', $ids )
-					->set_query_arg( 'orderby', 'post__in' )
-					->get_connection();
+				$resolver->set_query_arg( 'post_status', 'any' );
+				return $resolver->get_connection();
 			},
 		];
 

src/FieldType/Taxonomy.php

@@ -44,13 +44,9 @@ static function ( $id ) {
 								return null;
 							}
 
-							$resolver = new TermObjectConnectionResolver( $root, $args, $context, $info );
-							return $resolver
-							// Set the query to include only the IDs passed in from the field
-							// and orderby the ids
-							->set_query_arg( 'include', $ids )
-							->set_query_arg( 'orderby', 'include' )
-							->get_connection();
+							$args['where']['include'] = $ids;
+
+							return ( new TermObjectConnectionResolver( $root, $args, $context, $info ) )->get_connection();
 						},
 					];
 

src/FieldType/User.php

@@ -42,20 +42,31 @@ public static function register_field_type(): void {
 								$values = [];
 								if ( ! is_array( $value ) ) {
 									$values[] = $value;
+								} else {
+									$values = $value;
 								}
 
 								$value = array_map(
 									static function ( $user ) {
 										if ( is_array( $user ) && isset( $user['ID'] ) ) {
 											return absint( $user['ID'] );
 										}
+										if ( is_object( $user ) && isset( $user->ID ) ) {
+											return absint( $user->ID );
+										}
 										return absint( $user );
 									},
 									$values
 								);
 
+								if ( empty( $value ) ) {
+									return null;
+								}
+
+								$args['where']['include'] = $value;
 								$resolver = new UserConnectionResolver( $root, $args, $context, $info );
-								return $resolver->set_query_arg( 'include', $value )->set_query_arg( 'orderby', 'include' )->get_connection();
+								$resolver->set_query_arg( 'orderby', 'include' );
+								return $resolver->get_connection();
 							},
 						]
 					);