- update tests to support querying for a specific field via fragment on a node

- update test suite to add a published post by editor and published post by author so that more than 1 user are public in the environment
- update textFieldTest to test querying the text field on a post
- update UserFieldTest to test querying the user field (failing test)

Author: jasonbahl

tests/_support/WPUnit/AcfFieldTestCase.php

@@ -105,15 +105,22 @@ public function get_expected_block_fragment_response() {
 		return null;
 	}
 
-	/***
+	/**
+	 * Test class should override this with the fragment to test with
+	 *
 	 * @return string
 	 */
 	public function get_query_fragment(): string {
-		return '
-			fragment QueryFragment on AcfTestGroup {
-				testText
-			}
-		';
+		return 'null';
+	}
+
+	/**
+	 * Test class should override this with the expected value
+	 *
+	 * @return mixed
+	 */
+	public function get_expected_value() {
+		return 'null';
 	}
 
 	/**
@@ -971,12 +978,57 @@ public function testFieldWithNoGraphqlFieldNameAndNameThatStartsWithNumberDoesNo
 		acf_remove_local_field( $field_key );
 	}
 
+	public function testQueryFieldOnPostReturnsExpectedValue() {
+		$field_key = $this->register_acf_field();
+
+		// Save data to the post
+		update_field( $field_key, $this->get_data_to_store(), $this->published_post->ID );
+
+		$fragment = $this->get_query_fragment();
+
+		if ( 'null' === $fragment ) {
+			$this->markTestIncomplete( 'get_query_fragment() not defined' );
+		}
+
+		$expected_value = $this->get_expected_value();
+
+		if ( 'null' === $expected_value ) {
+			$this->markTestIncomplete( 'get_expected_value() not defined' );
+		}
+
+		$query = '
+		query AcfFieldOnPost ($id: ID!) {
+		  post( id: $id idType: DATABASE_ID) {
+		    databaseId
+		    __typename
+		    ...on WithAcfAcfTestGroup {
+		      acfTestGroup {
+		        ...AcfTestGroupFragment
+		      }
+		    }
+		  }
+		}
+		' . $fragment;
+
+		$actual = $this->graphql([
+			'query' => $query,
+			'variables' => [
+				'id' => $this->published_post->ID,
+			]
+		]);
+
+		self::assertQuerySuccessful( $actual, [
+			$this->expectedField( 'post.databaseId', $this->published_post->ID ),
+			$this->expectedField( 'post.__typename', 'Post' ),
+			$this->expectedField( 'post.acfTestGroup.' . $this->get_formatted_field_name(), $this->get_expected_value() )
+		]);
 
 
+	}
+
 	/**
 	 * @todo: implement the below tests
 	 */
-//	abstract public function testQueryFieldOnPostReturnsExpectedValue();
 //	abstract public function testQueryFieldOnPageReturnsExpectedValue();
 //	abstract public function testQueryFieldOnCommentReturnsExpectedValue();
 //	abstract public function testQueryFieldOnTagReturnsExpectedValue();
@@ -1088,7 +1140,7 @@ public function get_expected_clone_value() {
 	 */
 	public function testQueryCloneFieldOnPost(): void {
 
-		$this->markTestIncomplete( 'Clone Fields are being refactored...' );
+		// $this->markTestIncomplete( 'Clone Fields are being refactored...' );
 
 		// if ACF PRO is not active, skip the test
 		if ( ! defined( 'ACF_PRO' ) ) {

tests/_support/WPUnit/WPGraphQLAcfTestCase.php

@@ -123,6 +123,28 @@ public function setUp(): void {
 			],
 		]);
 
+		$this->published_post_by_editor = self::factory()->post->create_and_get([
+			'post_type' => 'post',
+			'post_status' => 'publish',
+			'post_author' => $this->editor->ID,
+			'post_title' => 'Test post by editor title',
+			'tax_input' => [
+				'post_tag' => [ $this->tag->term_id ],
+				'category' => [ $this->category->term_id ],
+			],
+		]);
+
+		$this->published_post_by_author = self::factory()->post->create_and_get([
+			'post_type' => 'post',
+			'post_status' => 'publish',
+			'post_author' => $this->author->ID,
+			'post_title' => 'Test post by author title',
+			'tax_input' => [
+				'post_tag' => [ $this->tag->term_id ],
+				'category' => [ $this->category->term_id ],
+			],
+		]);
+
 		$this->published_page = self::factory()->post->create_and_get([
 			'post_type' => 'page',
 			'post_status' => 'publish',

tests/wpunit/FieldTypes/TextFieldTest.php

@@ -57,10 +57,21 @@ public function get_block_query_fragment() {
 		';
 	}
 
-	public function get_block_data_to_store() {
+	public function get_block_data_to_store(): string {
 		return 'text value...';
 	}
 
+	public function get_query_fragment(): string {
+		return '
+		fragment AcfTestGroupFragment on AcfTestGroup {
+		  testText
+		}';
+	}
+
+	public function get_expected_value() {
+		return $this->get_data_to_store();
+	}
+
 	public function get_expected_block_fragment_response() {
 		return $this->get_block_data_to_store();
 	}

tests/wpunit/FieldTypes/UserFieldTest.php

@@ -28,8 +28,8 @@ public function get_expected_field_resolve_kind(): ?string {
 		return 'OBJECT';
 	}
 
-	public function get_data_to_store():string {
-		return $this->admin->ID;
+	public function get_data_to_store() {
+		return [ $this->admin->ID ];
 	}
 
 	public function get_block_query_fragment() {
@@ -60,6 +60,29 @@ public function get_expected_block_fragment_response() {
 		];
 	}
 
+	public function get_query_fragment(): string {
+		return '
+		fragment AcfTestGroupFragment on AcfTestGroup {
+		  testUser {
+		    nodes {
+		      __typename
+		      databaseId
+		    }
+		  }
+		}';
+	}
+
+	public function get_expected_value() {
+		return [
+			'nodes' => [
+				[
+					'__typename' => 'User',
+					'databaseId' => $this->admin->ID,
+				]
+			]
+		];
+	}
+
 	public function get_clone_value_to_save() {
 		return $this->get_data_to_store();
 	}