Merge pull request #182 from wp-graphql/fix/180-unexpected-type-for-hook_suffix

fix: admin_enqueue_scripts callback should expect a possible null value passed to it

Author: jasonbahl

src/Admin/PostTypeRegistration.php

@@ -167,11 +167,18 @@ public function add_cpt_registration_fields( array $args, array $post_type ): ar
 	}
 
 	/**
-	 * @param string $screen
+	 * Enqueue the admin scripts for the ACF Post Type settings.
+	 * This script is only enqueued on the ACF Post Type edit screen.
+	 *
+	 * @param ?string $screen
 	 */
-	public function enqueue_admin_scripts( string $screen ): void {
+	public function enqueue_admin_scripts( ?string $screen ): void {
 		global $post;
 
+		if ( empty( $screen ) ) {
+			return;
+		}
+
 		// if the screen is not a new post / edit post screen, do nothing
 		if ( ! ( 'post-new.php' === $screen || 'post.php' === $screen ) ) {
 			return;

src/Admin/TaxonomyRegistration.php

@@ -165,11 +165,18 @@ public function add_taxonomy_registration_fields( array $args, array $taxonomy )
 	}
 
 	/**
-	 * @param string $screen
+	 * Enqueue the admin scripts for the ACF Post Type settings.
+	 * This script is only enqueued on the ACF Taxonomy edit screen.
+	 *
+	 * @param ?string $screen
 	 */
-	public function enqueue_admin_scripts( string $screen ): void {
+	public function enqueue_admin_scripts( ?string $screen ): void {
 		global $post;
 
+		if ( empty( $screen ) ) {
+			return;
+		}
+
 		// if the screen is not a new post / edit post screen, do nothing
 		if ( ! ( 'post-new.php' === $screen || 'post.php' === $screen ) ) {
 			return;