Even more checks.

Author: johnbillion

ISSUES.md

@@ -24,6 +24,12 @@ Hooks with `@param` tags that have an empty variable name.
 
 _No hooks with empty variables._
 
+## Invalid Variable Names
+
+Hooks with `@param` tags where the variable is not a valid PHP variable name.
+
+_No hooks with invalid variable names._
+
 ## Empty Param Descriptions
 
 Hooks with `@param` tags that have an empty description.
@@ -48,3 +54,15 @@ Hooks where the number of `@param` tags does not match the `args` count.
 
 - `wp_default_autoload_value` — args: 4, params: 3 (wp-includes/option.php)
 - `wp_next_scheduled` — args: 4, params: 3 (wp-includes/cron.php)
+
+## Empty Param Types
+
+Hooks with `@param` tags that have empty or missing type arrays.
+
+_No hooks with empty param types._
+
+## Malformed Param Types
+
+Hooks with `@param` tags where types contain unexpected characters.
+
+_No hooks with malformed param types._

scripts/generate-issues.sh

@@ -95,6 +95,26 @@ fi
 
 echo "" >> "$OUTPUT_FILE"
 
+# Invalid Variable Names
+echo "## Invalid Variable Names" >> "$OUTPUT_FILE"
+echo "" >> "$OUTPUT_FILE"
+echo "Hooks with \`@param\` tags where the variable is not a valid PHP variable name." >> "$OUTPUT_FILE"
+echo "" >> "$OUTPUT_FILE"
+
+# Valid variable names match $[a-zA-Z_][a-zA-Z0-9_]*
+INVALID_VAR_NAMES_ACTIONS=$(jq -r '.hooks[] | .name as $name | .file as $file | .doc.tags[] | select(.name == "param" and .variable != "" and .variable != null and (.variable | test("^\\$[a-zA-Z_][a-zA-Z0-9_]*$") | not)) | "- `\($name)` — \(.variable) (\($file))"' hooks/actions.json 2>/dev/null | sort -u)
+INVALID_VAR_NAMES_FILTERS=$(jq -r '.hooks[] | .name as $name | .file as $file | .doc.tags[] | select(.name == "param" and .variable != "" and .variable != null and (.variable | test("^\\$[a-zA-Z_][a-zA-Z0-9_]*$") | not)) | "- `\($name)` — \(.variable) (\($file))"' hooks/filters.json 2>/dev/null | sort -u)
+
+INVALID_VAR_NAMES=$(echo -e "${INVALID_VAR_NAMES_ACTIONS}\n${INVALID_VAR_NAMES_FILTERS}" | grep -v '^$' | sort -u)
+
+if [ -n "$INVALID_VAR_NAMES" ]; then
+    echo "$INVALID_VAR_NAMES" >> "$OUTPUT_FILE"
+else
+    echo "_No hooks with invalid variable names._" >> "$OUTPUT_FILE"
+fi
+
+echo "" >> "$OUTPUT_FILE"
+
 # Empty Param Descriptions
 echo "## Empty Param Descriptions" >> "$OUTPUT_FILE"
 echo "" >> "$OUTPUT_FILE"
@@ -152,4 +172,43 @@ else
     echo "_No hooks with param count mismatches._" >> "$OUTPUT_FILE"
 fi
 
+echo "" >> "$OUTPUT_FILE"
+
+# Empty Param Types
+echo "## Empty Param Types" >> "$OUTPUT_FILE"
+echo "" >> "$OUTPUT_FILE"
+echo "Hooks with \`@param\` tags that have empty or missing type arrays." >> "$OUTPUT_FILE"
+echo "" >> "$OUTPUT_FILE"
+
+EMPTY_PARAM_TYPES_ACTIONS=$(jq -r '.hooks[] | .name as $name | .file as $file | .doc.tags[] | select(.name == "param" and (.types == null or .types == [] or (.types | length == 0))) | "- `\($name)` — \(.variable) (\($file))"' hooks/actions.json 2>/dev/null | sort -u)
+EMPTY_PARAM_TYPES_FILTERS=$(jq -r '.hooks[] | .name as $name | .file as $file | .doc.tags[] | select(.name == "param" and (.types == null or .types == [] or (.types | length == 0))) | "- `\($name)` — \(.variable) (\($file))"' hooks/filters.json 2>/dev/null | sort -u)
+
+EMPTY_PARAM_TYPES=$(echo -e "${EMPTY_PARAM_TYPES_ACTIONS}\n${EMPTY_PARAM_TYPES_FILTERS}" | grep -v '^$' | sort -u)
+
+if [ -n "$EMPTY_PARAM_TYPES" ]; then
+    echo "$EMPTY_PARAM_TYPES" >> "$OUTPUT_FILE"
+else
+    echo "_No hooks with empty param types._" >> "$OUTPUT_FILE"
+fi
+
+echo "" >> "$OUTPUT_FILE"
+
+# Malformed Param Types
+echo "## Malformed Param Types" >> "$OUTPUT_FILE"
+echo "" >> "$OUTPUT_FILE"
+echo "Hooks with \`@param\` tags where types contain unexpected characters." >> "$OUTPUT_FILE"
+echo "" >> "$OUTPUT_FILE"
+
+# Types should not contain spaces (except for specific patterns like "array<string, mixed>")
+MALFORMED_TYPES_ACTIONS=$(jq -r '.hooks[] | .name as $name | .file as $file | .doc.tags[] | select(.name == "param") | .variable as $var | .types[]? | select(test("^ | $|  ")) | "- `\($name)` — \($var): \(.) (\($file))"' hooks/actions.json 2>/dev/null | sort -u)
+MALFORMED_TYPES_FILTERS=$(jq -r '.hooks[] | .name as $name | .file as $file | .doc.tags[] | select(.name == "param") | .variable as $var | .types[]? | select(test("^ | $|  ")) | "- `\($name)` — \($var): \(.) (\($file))"' hooks/filters.json 2>/dev/null | sort -u)
+
+MALFORMED_TYPES=$(echo -e "${MALFORMED_TYPES_ACTIONS}\n${MALFORMED_TYPES_FILTERS}" | grep -v '^$' | sort -u)
+
+if [ -n "$MALFORMED_TYPES" ]; then
+    echo "$MALFORMED_TYPES" >> "$OUTPUT_FILE"
+else
+    echo "_No hooks with malformed param types._" >> "$OUTPUT_FILE"
+fi
+
 echo "Generated $OUTPUT_FILE"