Consolidate skip logic and extend patterns to /express-checkout

Author: hanna-meda

src/support/steps/broken-links.ts

@@ -57,13 +57,7 @@ Then('WP Rocket settings links are not broken', async function (this: ICustomWor
     }
 
     // Normalize and filter URLs
-    let normalizedUrls = normalizeUrls(allHrefs, basePageUrl);
-
-    // Exclude URLs that may trigger transactional side effects
-    const skipPatterns = [/\/renew\//i, /\/upgrade\//i];
-    normalizedUrls = new Set(
-        Array.from(normalizedUrls).filter(url => !skipPatterns.some(pattern => pattern.test(url)))
-    );
+    const normalizedUrls = normalizeUrls(allHrefs, basePageUrl);
 
     // Warn if no valid URLs found to validate
     if (normalizedUrls.size === 0) {
@@ -72,8 +66,9 @@ Then('WP Rocket settings links are not broken', async function (this: ICustomWor
         return;
     }
 
-    // Validate all collected URLs
-    const brokenLinks = await validateLinks(this.page, normalizedUrls, currentHost);
+    // Validate all collected URLs, excluding URLs that may trigger transactional side effects
+    const skipPatterns = [/\/renew\//i, /\/upgrade\//i, /\/express-checkout/i];
+    const brokenLinks = await validateLinks(this.page, normalizedUrls, currentHost, skipPatterns);
 
     // Report all broken links at once
     expect(brokenLinks, 'Broken links detected').toHaveLength(0);

utils/helpers.ts

@@ -649,6 +649,7 @@ export const normalizeUrls = (
  * @param {Page} page - The Playwright page object
  * @param {Set<string>} urls - Set of URLs to validate
  * @param {string} currentHost - Current host to distinguish internal from external URLs
+ * @param {RegExp[]} [skipPatterns=[]] - Optional array of regex patterns to skip URLs matching any pattern
  * @return {Promise<string[]>} - Array of broken link strings in format "STATUS: url"
  */
 export const validateLinks = async (
@@ -658,12 +659,14 @@ export const validateLinks = async (
     skipPatterns: RegExp[] = []
 ): Promise<string[]> => {
     const brokenLinks: string[] = [];
+    const validatedUrls: string[] = [];
 
     for (const url of urls) {
         // Skip URLs matching any skip pattern
         if (skipPatterns.some(pattern => pattern.test(url))) {
             continue;
         }
+        validatedUrls.push(url);
         try {
             const response = await page.request.get(url, { maxRedirects: 5, timeout: 30000 });
             const status = response.status();