fix: harden performance hints page restore checks (#328)

* fix: harden performance hints page restore checks

* Update src/support/hooks.ts

* remove an unnecessary wait

Author: hanna-meda

src/support/hooks.ts

@@ -19,10 +19,10 @@ import { ChromiumBrowser, chromium } from '@playwright/test';
 import { Sections } from '../common/sections';
 import { selectors as pluginSelectors } from "./../common/selectors";
 import { PageUtils } from "../../utils/page-utils";
-import { deleteFolder, isWprRelatedError } from "../../utils/helpers";
+import { deleteFolder, extractFromStdout, isWprRelatedError } from "../../utils/helpers";
 import {WP_SSH_ROOT_DIR,} from "../../config/wp.config";
 import { After, AfterAll, Before, BeforeAll, Status, setDefaultTimeout } from "@cucumber/cucumber";
-import {rename, exists, rm, testSshConnection, installRemotePlugin, activatePlugin, uninstallPlugin, readFile, isPluginActive, isPluginInstalled} from "../../utils/commands";
+import {rename, exists, rm, testSshConnection, installRemotePlugin, activatePlugin, uninstallPlugin, readFile, isPluginActive, isPluginInstalled, getPostDataFromTitle} from "../../utils/commands";
 import type { Selectors } from "../../utils/types";
 import type { Section } from "../../utils/types";
 // import {configurations, getWPDir} from "../../utils/configurations";
@@ -213,6 +213,25 @@ Before({tags: '@vr'}, async function (this: ICustomWorld) {
     this.wprOption = option;
 });
 
+/**
+ * Before each test scenario with the @performancehints tag, verifies required pages exist.
+ */
+Before({tags: '@performancehints'}, async function (this: ICustomWorld) {
+    const requiredPages = ['atf-lrc-1', 'atf-lrc-2'];
+    
+    for (const pageName of requiredPages) {
+        const pageDataStdout = await getPostDataFromTitle(pageName, 'publish', 'ID,post_status');
+        const pageData = await extractFromStdout(pageDataStdout);
+        
+        if (!pageData || pageData.length === 0) {
+            throw new Error(
+                `Required test page '${pageName}' does not exist. ` +
+                `Template loader plugin may have failed.`
+            );
+        }
+    }
+});
+
 /**
  * After each test scenario, performs cleanup tasks and captures screenshots and videos in case of failure.
  */

src/support/steps/performance-hints.ts

@@ -140,5 +140,18 @@ When ('{string} page is deleted', async function (this: ICustomWorld, permalink:
 Then ('untrash and republish {string} page', async function (this: ICustomWorld, permalink: string) {
     const postDataStdout = await getPostDataFromTitle(permalink, 'trash', 'ID,post_title');
     const postData = await extractFromStdout(postDataStdout);
+    
+    if (!postData || postData.length === 0) {
+        throw new Error(`Failed to find page '${permalink}' in trash`);
+    }
+    
     await updatePostStatus(parseInt(postData[0].ID, 10), 'publish');
+    
+    // Verify it actually worked
+    const verifyStdout = await getPostDataFromTitle(permalink, 'publish', 'ID,post_status');
+    const verifyData = await extractFromStdout(verifyStdout);
+    
+    if (!verifyData || verifyData.length === 0 || verifyData[0].post_status !== 'publish') {
+        throw new Error(`Failed to restore page '${permalink}' to published status`);
+    }
 });