Skip to content

Commit 03e44ab

Browse files
authored
Merge pull request #368 from wp-media/fix/imagify-install
Fixes #156
2 parents 2e9a972 + 064aba1 commit 03e44ab

File tree

6 files changed

+162
-464
lines changed

6 files changed

+162
-464
lines changed

inc/admin/ui/css/admin.css

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,17 @@ p.description.file-error{color:#F00}
1414
.rocket-renew{font-weight:400}
1515
.rkt-disabled{color:#CCC}
1616
.rkt-note{font-style:italic; font-weight:bold; font-size:smaller}
17-
.rkt-imagify-notice.rkt-imagify-notice{position:relative; display:-webkit-box; display:-webkit-flex; display:-ms-flexbox; display:flex; -webkit-box-align:center; -webkit-align-items:center; -ms-flex-align:center; -ms-grid-row-align:center; align-items:center; padding:5px 45px 5px 0; border:0 none; box-shadow:none; color:#FFF; background:#2e3243}
17+
.rkt-imagify-notice.rkt-imagify-notice{position:relative; display:-webkit-box; display:-webkit-flex; display:-ms-flexbox; display:flex; -webkit-box-align:center; -webkit-align-items:center; -ms-flex-align:center; -ms-grid-row-align:center; align-items:center; float:none; width:auto; padding:5px 45px 5px 0; border:0 none; box-shadow:none; color:#FFF; background:#2e3243}
1818
.rkt-imagify-notice .rkt-cross{position:absolute; right:8px; top:50%; width:22px; height:22px; padding:0; margin-top:-11px; background:#FFF; color:#2e3243; border-radius:50%; transition:all .275s}
1919
.rkt-imagify-notice .rkt-cross .dashicons{position:relative; top:2px; left:1px; transition:all .275s}
2020
.rkt-imagify-notice .rkt-cross:hover{background:#2e3243}
2121
.rkt-imagify-notice .rkt-cross:hover .dashicons{color:#FFF}
2222
.rkt-imagify-notice .rkt-imagify-logo, .rkt-imagify-notice .rkt-imagify-cta{-webkit-flex-shrink: 0;-ms-flex-negative: 0;flex-shrink: 0;}
2323
.rkt-imagify-notice .rkt-imagify-logo{width:160px!important; text-align:right; padding:0 15px; line-height:0.8}
2424
.rkt-imagify-notice .rkt-imagify-msg{width:100%!important; padding:0 15px; }
25-
.rkt-imagify-notice .rkt-imagify-cta{width:200px;!important; -webkit-box-flex: 1; -webkit-flex-grow: 1; -ms-flex-positive: 1; flex-grow: 1; -webkit-flex-basis: 200px; -ms-flex-preferred-size: 200px; flex-basis: 200px; }
25+
.rkt-imagify-notice .rkt-imagify-cta{padding-top: 7px; -webkit-box-flex: 1; -webkit-flex-grow: 1; -ms-flex-positive: 1; flex-grow: 1; -webkit-flex-basis: 200px; -ms-flex-preferred-size: 200px; flex-basis: 200px; }
2626
.rkt-imagify-notice .button.button{height:auto; font-weight:600; font-size:14px; box-shadow:0 3px 0 rgba(0,0,0,.15); border:0 none; padding:4px 18px; background:#40B1D0; text-shadow:1px 1px 1px rgba(0,0,0,.2)}
27+
.rkt-imagify-cta .thickbox{display: inline-block;margin-top:.5em;color:rgba(255,255,255,.5);}
2728
@media (max-width:650px){.rkt-imagify-notice{-webkit-flex-wrap:wrap; -ms-flex-wrap:wrap; flex-wrap:wrap}
2829
.rkt-imagify-notice .rkt-imagify-msg,
2930
.rkt-imagify-notice .rkt-imagify-cta,

inc/admin/ui/enqueue.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,9 @@ function __rocket_admin_print_styles() {
8989
add_action( 'admin_print_styles-upload.php', '__rocket_enqueue_modal_plugin' );
9090
add_action( 'admin_print_styles-settings_page_' . WP_ROCKET_PLUGIN_SLUG, '__rocket_enqueue_modal_plugin' );
9191
function __rocket_enqueue_modal_plugin() {
92-
wp_enqueue_style( 'thickbox' );
9392
wp_enqueue_style( 'plugin-install' );
9493

9594
wp_enqueue_script( 'plugin-install' );
96-
wp_enqueue_script( 'tgm-modal-wp-rocket', WP_ROCKET_ADMIN_UI_JS_URL . 'vendors/tgm-modal.min.js', array( 'jquery' ), WP_ROCKET_VERSION, true );
97-
}
95+
wp_enqueue_script( 'updates' );
96+
add_thickbox();
97+
}

inc/admin/ui/js/vendors/tgm-modal.min.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

inc/admin/ui/notices.php

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,15 @@ function __rocket_imagify_notice() {
527527
$action_url = $is_imagify_installed ?
528528
rocket_get_plugin_activation_link( $imagify_plugin )
529529
:
530-
add_query_arg(
530+
wp_nonce_url( add_query_arg(
531+
array(
532+
'action' => 'install-plugin',
533+
'plugin' => 'imagify',
534+
),
535+
admin_url( 'update.php' )
536+
), 'install-plugin_imagify' );
537+
538+
$details_url = add_query_arg(
531539
array(
532540
'tab' => 'plugin-information',
533541
'plugin' => 'imagify',
@@ -538,7 +546,7 @@ function __rocket_imagify_notice() {
538546
admin_url( 'plugin-install.php' )
539547
);
540548

541-
$classes = $is_imagify_installed ? '' : ' tgm-plugin-update-modal';
549+
$classes = $is_imagify_installed ? '' : ' install-now';
542550
$cta_txt = $is_imagify_installed ? esc_html__( 'Activate Imagify', 'rocket' ) : esc_html__( 'Install Imagify for Free', 'rocket' );
543551

544552
$dismiss_url = wp_nonce_url(
@@ -547,7 +555,7 @@ function __rocket_imagify_notice() {
547555
);
548556
?>
549557

550-
<div class="updated rkt-imagify-notice">
558+
<div id="plugin-filter" class="updated plugin-card plugin-card-imagify rkt-imagify-notice">
551559
<a href="<?php echo $dismiss_url; ?>" class="rkt-cross"><span class="dashicons dashicons-no"></span></a>
552560

553561
<p class="rkt-imagify-logo">
@@ -557,7 +565,10 @@ function __rocket_imagify_notice() {
557565
<?php _e( 'Speed up your website and boost your SEO by reducing image file sizes without losing quality with Imagify.', 'rocket' ); ?>
558566
</p>
559567
<p class="rkt-imagify-cta">
560-
<a href="<?php echo $action_url; ?>" class="button button-primary<?php echo $classes; ?>"><?php echo $cta_txt; ?></a>
568+
<a data-slug="imagify" href="<?php echo $action_url; ?>" class="button button-primary<?php echo $classes; ?>"><?php echo $cta_txt; ?></a>
569+
<?php if ( ! $is_imagify_installed ) : ?>
570+
<br><a data-slug="imagify" data-name="Imagify Image Optimizer" class="thickbox open-plugin-details-modal" href="<?php echo $details_url; ?>"><?php _e( 'More details', 'rocket' ); ?></a>
571+
<?php endif; ?>
561572
</p>
562573
</div>
563574

@@ -641,4 +652,4 @@ function rocket_cloudflare_update_settings() {
641652
</div>
642653
<?php }
643654
}
644-
}
655+
}

languages/rocket-fr_FR.mo

-61 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)