Fix dropdown value with numeric values #225

Author: frozzare

src/properties/class-papi-property-dropdown.php

@@ -125,7 +125,7 @@ public function html() {
 			if ( $settings->multiple ) {
 				$selected = in_array( $value, $settings->selected, true );
 			} else {
-				$selected = papi_convert_to_string( $value ) === $settings->selected;
+				$selected = papi_convert_to_string( $value ) === papi_convert_to_string( $settings->selected );
 			}
 
 			$options_html[] = papi_html_tag( 'option', [

tests/cases/properties/class-papi-property-dropdown-test.php

@@ -5,12 +5,14 @@
  */
 class Papi_Property_Dropdown_Test extends Papi_Property_Test_Case {
 
-	public $slugs = ['dropdown_test', 'dropdown_test_2', 'dropdown_test_3'];
+	public $slugs = ['dropdown_test', 'dropdown_test_2', 'dropdown_test_3', 'dropdown_test_4'];
 
 	public function get_value() {
 		$args = func_get_args();
 		$args[0] = isset( $args[0] ) ? $args[0] : $this->slugs[0];
 		switch ( $args[0] ) {
+			case 'dropdown_test_4':
+				return 2;
 			case 'dropdown_test_3':
 				return [1, 2, 3];
 			default:
@@ -22,6 +24,8 @@ public function get_expected() {
 		$args = func_get_args();
 		$args[0] = isset( $args[0] ) ? $args[0] : $this->slugs[0];
 		switch ( $args[0] ) {
+			case 'dropdown_test_4':
+				return 2;
 			case 'dropdown_test_3':
 				return [1, 2, 3];
 			default:

tests/data/page-types/boxes/properties.php

@@ -91,6 +91,19 @@
 		]
 	] ),
 
+	// Dropdown 4
+	papi_property( [
+		'type'     => 'dropdown',
+		'title'    => 'Dropdown test_4',
+		'slug'     => 'dropdown_test_4',
+		'settings' => [
+			'items' => [
+				'White' => 1,
+				'Black' => 2
+			]
+		]
+	] ),
+
 	// Editor
 	papi_property( [
 		'type'  => 'editor',