From eaf96d5965aa5943a4a3cd59d7a09377745d125f Mon Sep 17 00:00:00 2001 From: rianrietveld Date: Sat, 29 Nov 2025 07:25:08 +0100 Subject: [PATCH 1/5] delete removal of href from active link in menu --- assets/js/wp-a11y-docs.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/assets/js/wp-a11y-docs.js b/assets/js/wp-a11y-docs.js index 2568b641a..ee4467301 100644 --- a/assets/js/wp-a11y-docs.js +++ b/assets/js/wp-a11y-docs.js @@ -497,15 +497,12 @@ /** * Scrolls sidebar navigation so the active link is centered. * - * Also removes the link's `href` to prevent accidental reloads. - * * @function scrollNav */ function scrollNav() { const targetLink = navLink(); if (targetLink) { targetLink.scrollIntoView({ block: "center" }); - targetLink.removeAttribute('href'); } } From ec836197dad1196b5b53c938dc161aed331e8d97 Mon Sep 17 00:00:00 2001 From: rianrietveld Date: Sat, 29 Nov 2025 07:39:17 +0100 Subject: [PATCH 2/5] fix aria-expanded toggle --- assets/js/wp-a11y-docs.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/js/wp-a11y-docs.js b/assets/js/wp-a11y-docs.js index ee4467301..8ca12f729 100644 --- a/assets/js/wp-a11y-docs.js +++ b/assets/js/wp-a11y-docs.js @@ -87,7 +87,7 @@ if (target) { e.preventDefault(); - target.ariaExpanded = target.parentNode.classList.toggle('active'); + target.ariaExpanded = target.parentNode.classList.toggle('true'); } }); From e258e54fd77ad42d079f128b94c90022dc8f32c9 Mon Sep 17 00:00:00 2001 From: rianrietveld Date: Sat, 29 Nov 2025 07:45:20 +0100 Subject: [PATCH 3/5] remove layout: null --- assets/js/wp-a11y-docs.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/assets/js/wp-a11y-docs.js b/assets/js/wp-a11y-docs.js index 8ca12f729..14ea5dfb7 100644 --- a/assets/js/wp-a11y-docs.js +++ b/assets/js/wp-a11y-docs.js @@ -1,7 +1,3 @@ ---- - layout: null ---- - (function (jtd, undefined) { // From 32b6cbb54c8a2a2187c2e7bf65215bb7b9c0e1b4 Mon Sep 17 00:00:00 2001 From: rianrietveld Date: Sat, 29 Nov 2025 08:45:21 +0100 Subject: [PATCH 4/5] add toggle aria-axpanded again --- assets/js/wp-a11y-docs.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/assets/js/wp-a11y-docs.js b/assets/js/wp-a11y-docs.js index 14ea5dfb7..f719eaa99 100644 --- a/assets/js/wp-a11y-docs.js +++ b/assets/js/wp-a11y-docs.js @@ -83,7 +83,7 @@ if (target) { e.preventDefault(); - target.ariaExpanded = target.parentNode.classList.toggle('true'); + target.ariaExpanded = target.parentNode.classList.toggle('active'); } }); @@ -523,6 +523,7 @@ } if (target) { target.classList.add('active'); + target.classList.toggle('active', true); target = target.parentNode; } } @@ -593,17 +594,17 @@ jtd.onReady(function() { const input = query; if (!resultsContainer) return; - + // Handle empty search query if (!query) { // Check if there was a q parameter but it was empty if (urlParams.has("q")) { let pageTitle = document.querySelector('title'); let h1 = document.querySelector('h1'); - + if (pageTitle) pageTitle.innerText = 'Empty Search Query - No Results'; if (h1) h1.innerText = 'No Search Term Entered'; - + resultsContainer.innerHTML = '

Please enter a search term to find relevant content.

'; } return; From 7c9e80445ad1fed8949258b398ade0137ccb9bb2 Mon Sep 17 00:00:00 2001 From: rianrietveld Date: Sat, 29 Nov 2025 08:54:20 +0100 Subject: [PATCH 5/5] try to fix screen reader feedback for search --- _layouts/default.html | 2 +- assets/js/wp-a11y-docs.js | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/_layouts/default.html b/_layouts/default.html index f15759266..23c09cef7 100644 --- a/_layouts/default.html +++ b/_layouts/default.html @@ -43,6 +43,6 @@ -
+
diff --git a/assets/js/wp-a11y-docs.js b/assets/js/wp-a11y-docs.js index f719eaa99..bcdfcd63b 100644 --- a/assets/js/wp-a11y-docs.js +++ b/assets/js/wp-a11y-docs.js @@ -1,4 +1,8 @@ -(function (jtd, undefined) { +--- + layout: null +--- + + (function (jtd, undefined) { // // ---------------------------------------------------------