[CICD-428] Remove notify step from e2e deploy (#117)

Removes the notify step of our e2e workflow. The failures in this workflow have consistently been unrelated to the action itself and are therefore not actionable. Instead, they indicate an issue with some other service we depend on (GitHub, Docker Hub, SSH Gateway, WPE User Portal). These services are either out of our control or are already monitored in other ways.

Bonus: this gets rid of a dependency on voxmedia/github-action-slack-notify-build, which has been deprecated.

Author: apmatthews

.github/workflows/e2e-deploy.yml

@@ -41,18 +41,3 @@ jobs:
       - name: Validate deploy results
         run: |
           [ ${{ fromJson(steps.fetchResult.outputs.response).status }} = "success" ] || exit 1
-  notify:
-    runs-on: ubuntu-latest
-    if: ${{ !cancelled() }}
-    needs: run_action
-    steps:
-      - name: Notify slack on failure
-        if: needs.run_action.result == 'failure' && github.ref == 'refs/heads/main'
-        env:
-          SLACK_BOT_TOKEN: ${{ secrets.SLACK_NOTIFICATIONS_BOT_TOKEN }}
-        uses: voxmedia/github-action-slack-notify-build@v1
-        with:
-          # Channel: status-github-action
-          channel_id: C03QDL9U0TW
-          status: FAILED
-          color: danger