Updated package name. Thanks @theodesp . Updated logic of pre-release to catch some errors. Thanks @ahuseyn

Author: colinmurphy

.github/workflows/pre-release.yml

@@ -7,6 +7,9 @@ on:
     paths:
       - "plugins/**"
 
+permissions:
+  contents: write # Allow actions to read and write repository contents
+  actions: read # Allow actions to read repository metadata but not write
 jobs:
   tag-pre-release:
     runs-on: ubuntu-latest
@@ -36,10 +39,22 @@ jobs:
       - name: Get changed plugin directory
         id: plugin
         run: |
-          git fetch --prune --unshallow || true
+          git fetch --prune --unshallow
           plugin=$(git diff --name-only HEAD~1 HEAD | grep '^plugins/' | head -1 | cut -d/ -f2)
           echo "plugin_slug=$plugin" >> $GITHUB_OUTPUT
 
+      - name: Validate plugin detection
+        run: |
+          if [ -z "${{ steps.plugin.outputs.plugin_slug }}" ]; then
+            echo "No plugin detected in changes"
+            exit 1
+          fi
+
+          if [ ! -d "plugins/${{ steps.plugin.outputs.plugin_slug }}" ]; then
+            echo "Plugin directory does not exist"
+            exit 1
+          fi
+
       - name: Install dependencies
         run: pnpm install
 
@@ -58,42 +73,74 @@ jobs:
         id: metadata
         run: |
           PLUGIN_DIR="plugins/${{ steps.plugin.outputs.plugin_slug }}"
+
+          if [ ! -f "$PLUGIN_DIR/package.json" ]; then
+            echo "package.json not found in $PLUGIN_DIR"
+            exit 1
+          fi
+
           package_name=$(jq -r '.name // empty' "$PLUGIN_DIR/package.json")
           package_version=$(jq -r '.version // empty' "$PLUGIN_DIR/package.json")
 
-          if [ -z "$package_name" ] || [ -z "$package_version" ]; then
-              echo "Missing name or version in $PLUGIN_DIR/package.json"
+          if [ -z "$package_name" ] || [ "$package_name" = "null" ] || [ "$package_name" = "empty" ]; then
+              echo "Missing or invalid name in $PLUGIN_DIR/package.json"
+              exit 1
+          fi
+
+          if [ -z "$package_version" ] || [ "$package_version" = "null" ] || [ "$package_version" = "empty" ]; then
+              echo "Missing or invalid version in $PLUGIN_DIR/package.json"
               exit 1
           fi
 
           echo "package_name=$package_name" >> $GITHUB_OUTPUT
           echo "package_version=$package_version" >> $GITHUB_OUTPUT
-          echo "PLUGIN_DIR=$PLUGIN_DIR" >> $GITHUB_ENV
+          echo "PLUGIN_DIR=$PLUGIN_DIR" >> $GITHUB_OUTPUT
 
       - name: Create Git tag
         run: |
           TAG_NAME="${{ steps.metadata.outputs.package_name }}-${{ steps.metadata.outputs.package_version }}"
+
+          # Check if tag already exists
+          if git rev-parse "$TAG_NAME" >/dev/null 2>&1; then
+            echo "Tag $TAG_NAME already exists. Skipping tag creation."
+            exit 0
+          fi
+
           git config user.name "github-actions"
           git config user.email "[email protected]"
           git tag "$TAG_NAME"
           git push origin "$TAG_NAME"
 
       - name: Run composer install
-        working-directory: ${{ env.PLUGIN_DIR }}
+        working-directory: ${{ steps.metadata.outputs.PLUGIN_DIR }}
         run: composer install --no-dev --optimize-autoloader
 
+      - name: Validate composer setup
+        working-directory: ${{ steps.metadata.outputs.PLUGIN_DIR }}
+        run: |
+          composer validate --no-check-publish --no-check-lock
+
       - name: Create plugin archive
-        working-directory: ${{ env.PLUGIN_DIR }}
+        working-directory: ${{ steps.metadata.outputs.PLUGIN_DIR }}
         run: |
-          mkdir -p plugin-build || true
-          composer archive -vvv --format=zip --file="plugin-build/${{ steps.plugin.outputs.plugin_slug }}.zip" --dir="."
+          mkdir -p plugin-build
+          composer archive --format=zip --file="plugin-build/${{ steps.plugin.outputs.plugin_slug }}.zip"
+
+          # Verify archive was created
+          if [ ! -f "plugin-build/${{ steps.plugin.outputs.plugin_slug }}.zip" ]; then
+            echo "Failed to create plugin archive"
+            exit 1
+          fi
+
+          echo "Archive created successfully: $(ls -lh plugin-build/${{ steps.plugin.outputs.plugin_slug }}.zip)"
 
       - name: Upload archive to GitHub Release
         uses: softprops/action-gh-release@v2
         with:
           tag_name: ${{ steps.metadata.outputs.package_name }}-${{ steps.metadata.outputs.package_version }}
           name: "Pre-release ${{ steps.metadata.outputs.package_version }} for ${{ steps.metadata.outputs.package_name }}"
           prerelease: true
-          files: ${{ env.PLUGIN_DIR }}/plugin-build/${{ steps.plugin.outputs.plugin_slug }}.zip
+          files: |
+            ${{ steps.metadata.outputs.PLUGIN_DIR }}/plugin-build/${{ steps.plugin.outputs.plugin_slug }}.zip
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}