Fixed code quality issues with phpcs

Author: colinmurphy

plugins/wpgraphql-logging/src/Admin/View/List/List_Table.php

@@ -118,6 +118,10 @@ public function get_bulk_actions(): array {
 	 *
 	 * @phpcs:disable WordPress.Security.NonceVerification.Missing
 	 * @phpcs:disable WordPress.Security.NonceVerification.Recommended
+	 * @phpcs:disable Generic.Metrics.NestingLevel.TooHigh
+	 * @phpcs:disable Generic.Metrics.CyclomaticComplexity.TooHigh
+	 * @phpcs:disable Generic.Metrics.CyclomaticComplexity.MaxExceeded
+	 * @phpcs:disable SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh
 	 */
 	public function process_bulk_action(): void {
 		$action = $this->current_action();
@@ -126,8 +130,8 @@ public function process_bulk_action(): void {
 			return;
 		}
 
-		$nonce_action = 'bulk-' . $this->_args['plural'];
-		$nonce_value  = $_REQUEST['_wpnonce'] ?? '';
+		$nonce_action = 'bulk-' . esc_attr( $this->_args['plural'] );
+		$nonce_value  = isset( $_REQUEST['_wpnonce'] ) ? sanitize_text_field( wp_unslash( (string) $_REQUEST['_wpnonce'] ) ) : '';
 
 		$nonce = is_string( $nonce_value ) ? $nonce_value : '';
 
@@ -141,9 +145,9 @@ public function process_bulk_action(): void {
 		// WordPress sometimes sends 'delete' for selected items.
 		if ( in_array( $action, [ 'delete', 'bulk_delete' ], true ) && ! empty( $_REQUEST['log'] ) ) {
 			$ids = array_map( 'absint', (array) $_REQUEST['log'] );
-			// Remove redundant empty check since array_map always returns array
+			// Remove redundant empty check since array_map always returns array.
 			foreach ( $ids as $id ) {
-				if ( $id > 0 ) { // Only process valid IDs
+				if ( $id > 0 ) { // Only process valid IDs.
 					$this->repository->delete( $id );
 				}
 			}
@@ -164,9 +168,9 @@ public function process_bulk_action(): void {
 		$filter_keys       = [ 'level_filter', 'start_date', 'end_date' ];
 
 		foreach ( $filter_keys as $key ) {
-			$value = $_REQUEST[ $key ] ?? null;
+			$value = isset( $_REQUEST[ $key ] ) ? sanitize_text_field( wp_unslash( (string) $_REQUEST[ $key ] ) ) : null;
 			if ( ! empty( $value ) && is_string( $value ) ) {
-				$preserved_filters[ $key ] = sanitize_text_field( wp_unslash( $value ) );
+				$preserved_filters[ $key ] = $value;
 			}
 		}
 

plugins/wpgraphql-logging/src/Admin/View/Templates/wpgraphql-logger-filters.php

@@ -6,34 +6,35 @@
 	exit;
 }
 
-// Current filter values.
-$current_level      = $_POST['level_filter'] ?? '';
-$current_start_date = $_POST['start_date'] ?? '';
-$current_end_date   = $_POST['end_date'] ?? '';
+$wpgraphql_logging_current_level      = isset( $_POST['level_filter'] ) ? sanitize_text_field( wp_unslash( $_POST['level_filter'] ) ) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Missing
+$wpgraphql_logging_current_start_date = isset( $_POST['start_date'] ) ? sanitize_text_field( wp_unslash( $_POST['start_date'] ) ) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Missing
+$wpgraphql_logging_current_end_date   = isset( $_POST['end_date'] ) ? sanitize_text_field( wp_unslash( $_POST['end_date'] ) ) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Missing
 
-$log_levels = [ 'debug', 'info', 'notice', 'warning', 'error', 'critical', 'alert', 'emergency' ];
+// Currently only use info and error.
+$wpgraphql_logging_log_levels = [ 'info', 'error' ];
+$wpgraphql_logging_log_levels = apply_filters( 'wpgraphql_logging_log_levels', $wpgraphql_logging_log_levels );
 ?>
 
 <div class="alignleft actions" style="display: inline-flex; align-items: center; gap: 8px; margin-right: 10px;">
 	<input type="text"
 			name="start_date"
 			class="wpgraphql-logging-datepicker"
 			placeholder="Start Date"
-			value="<?php echo esc_attr( $current_start_date ); ?>"
+			value="<?php echo esc_attr( $wpgraphql_logging_current_start_date ); ?>"
 			style="width: 120px;" />
 
 	<input type="text"
 			name="end_date"
 			class="wpgraphql-logging-datepicker"
 			placeholder="End Date"
-			value="<?php echo esc_attr( $current_end_date ); ?>"
+			value="<?php echo esc_attr( $wpgraphql_logging_current_end_date ); ?>"
 			style="width: 120px;" />
 
 	<select name="level_filter" style="width: 120px;">
 		<option value="">All Levels</option>
-		<?php foreach ( $log_levels as $level ) : ?>
-			<option value="<?php echo esc_attr( $level ); ?>" <?php selected( $current_level, $level ); ?>>
-				<?php echo esc_html( ucfirst( $level ) ); ?>
+		<?php foreach ( $wpgraphql_logging_log_levels as $wpgraphql_logging_level ) : ?>
+			<option value="<?php echo esc_attr( $wpgraphql_logging_level ); ?>" <?php selected( $wpgraphql_logging_current_level, $wpgraphql_logging_level ); ?>>
+				<?php echo esc_html( ucfirst( $wpgraphql_logging_level ) ); ?>
 			</option>
 		<?php endforeach; ?>
 	</select>

plugins/wpgraphql-logging/src/Events/Events.php

@@ -60,5 +60,4 @@ final class Events {
 	 * @var string
 	 */
 	public const REQUEST_RESULTS = 'graphql_request_results';
-
 }

plugins/wpgraphql-logging/src/Logger/LoggingHelper.php

@@ -28,7 +28,7 @@ protected function is_logging_enabled( array $config, ?string $query_string = nu
 			$is_enabled = false;
 		}
 
-		// Do not log the seedQuery for Faust.js
+		// Do not log the seedQuery for Faust.js.
 		if ( $is_enabled && ( 'query GetSeedNode' === trim( $query_string ) ) ) {
 			$is_enabled = false;
 		}