Refactored Post_Preview_Service to only set data on get methods. Issue is setting values in the constructor means ACF hooks have not fired.

Author: colinmurphy

plugins/hwp-previews/src/Preview/Post/Post_Preview_Service.php

@@ -35,22 +35,11 @@ class Post_Preview_Service {
 	 */
 	protected $parent_post_statuses = [];
 
-	/**
-	 * Constructor for the Post_Preview_Service class.
-	 *
-	 * Initializes the allowed post-types and statuses for previews.
-	 */
-	public function __construct() {
-		$this->set_post_types();
-		$this->set_post_statuses();
-		$this->set_post_parent_statuses();
-	}
-
 	/**
 	 * @return array<string>
 	 */
 	public function get_allowed_post_types(): array {
-		return $this->post_types;
+		return $this->get_post_types();
 	}
 
 	/**
@@ -59,6 +48,11 @@ public function get_allowed_post_types(): array {
 	 * @return array<string>
 	 */
 	public function get_post_statuses(): array {
+		$post_statuses = $this->post_statuses;
+		if ([] !== $post_statuses) {
+			return $post_statuses;
+		}
+		$this->set_post_statuses();
 		return $this->post_statuses;
 	}
 
@@ -68,6 +62,11 @@ public function get_post_statuses(): array {
 	 * @return array<string>
 	 */
 	public function get_post_types(): array {
+		$post_types = $this->post_types;
+		if ([] !== $post_types) {
+			return $post_types;
+		}
+		$this->set_post_types();
 		return $this->post_types;
 	}
 
@@ -77,6 +76,11 @@ public function get_post_types(): array {
 	 * @return array<string>
 	 */
 	public function get_parent_post_statuses(): array {
+		$parent_post_statuses = $this->parent_post_statuses;
+		if ([] !== $parent_post_statuses) {
+			return $parent_post_statuses;
+		}
+		$this->set_post_parent_statuses();
 		return $this->parent_post_statuses;
 	}