fix: prevent early text domain loading in plugin triggering notice

Author: josephfusco

plugins/wp-graphql-headless-webhooks/access-functions.php

@@ -33,7 +33,7 @@
 	function register_webhook_type( string $type, array $args = [] ): void {
 		/** @psalm-suppress HookNotFound */
 		if ( did_action( 'graphql_register_webhooks' ) > 0 ) {
-			_doing_it_wrong( 'register_webhook_type', __( 'Call this before WebhookRegistry::init', 'wp-graphql-headless-webhooks' ), '0.1.0' );
+			_doing_it_wrong( 'register_webhook_type', 'Call this before WebhookRegistry::init', '0.1.0' );
 
 			return;
 		}
@@ -137,7 +137,7 @@ function register_graphql_event( Event $event ): void {
 	if ( did_action( 'graphql_register_events' ) ) {
 		_doing_it_wrong(
 			__FUNCTION__,
-			esc_html__( 'Call this before EventRegistry::init', 'wp-graphql-webhooks' ),
+			'Call this before EventRegistry::init',
 			'0.0.1'
 		);
 		return;

plugins/wp-graphql-headless-webhooks/src/Autoloader.php

@@ -60,7 +60,7 @@ protected static function require_autoloader( string $autoloader_file ): bool {
 	 * Displays a notice if the autoloader is missing.
 	 */
 	protected static function missing_autoloader_notice(): void {
-		$error_message = __( 'Headless Webhooks for WPGraphQL: The Composer autoloader was not found. If you installed the plugin from the GitHub source, make sure to run `composer install`.', 'wp-graphql-headless-webhooks' );
+		$error_message = 'Headless Webhooks for WPGraphQL: The Composer autoloader was not found. If you installed the plugin from the GitHub source, make sure to run `composer install`.';
 
 		if ( defined( 'WP_DEBUG' ) && WP_DEBUG ) {
 			error_log( esc_html( $error_message ) ); // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_error_log -- This is a development notice.

plugins/wp-graphql-headless-webhooks/src/Plugin.php

@@ -102,14 +102,14 @@ private function includes(): void {
 		 * Prevent cloning.
 		 */
 		public function __clone() {
-			_doing_it_wrong( __FUNCTION__, esc_html__( 'The plugin main class should not be cloned.', 'wp-graphql-headless-webhooks' ), '0.0.1' );
+			_doing_it_wrong( __FUNCTION__, 'The plugin main class should not be cloned.', '0.0.1' );
 		}
 
 		/**
 		 * Prevent unserializing.
 		 */
 		public function __wakeup(): void {
-			_doing_it_wrong( __FUNCTION__, esc_html__( 'De-serializing instances of the plugin main class is not allowed.', 'wp-graphql-headless-webhooks' ), '0.0.1' );
+			_doing_it_wrong( __FUNCTION__, 'De-serializing instances of the plugin main class is not allowed.', '0.0.1' );
 		}
 	}
 

plugins/wp-graphql-headless-webhooks/wp-graphql-headless-webhooks.php

@@ -30,6 +30,11 @@
 	exit;
 }
 
+// Define text domain constant to use instead of string literals
+if ( ! defined( 'WPGRAPHQL_HEADLESS_WEBHOOKS_TEXT_DOMAIN' ) ) {
+	define( 'WPGRAPHQL_HEADLESS_WEBHOOKS_TEXT_DOMAIN', 'wp-graphql-headless-webhooks' );
+}
+
 // Load the autoloader.
 require_once __DIR__ . '/src/Autoloader.php';
 if ( ! \WPGraphQL\Webhooks\Autoloader::autoload() ) {
@@ -101,6 +106,9 @@ function graphql_headless_webhooks_init(): void {
 	$not_ready = graphql_headless_webhooks_dependencies_not_ready();
 
 	if ( $not_ready === [] && defined( 'WPGRAPHQL_HEADLESS_WEBHOOKS_PLUGIN_DIR' ) ) {
+		// Load text domain at the init hook
+		add_action('init', 'WPGraphQL\Webhooks\graphql_headless_webhooks_load_textdomain');
+		
 		require_once WPGRAPHQL_HEADLESS_WEBHOOKS_PLUGIN_DIR . 'src/Plugin.php';
 		$plugin = new \WPGraphQL\Webhooks\Plugin();
 		$plugin::instance();
@@ -115,9 +123,10 @@ static function () use ($dep) {
 			<div class="error notice">
 				<p>
 					<?php
+						// Using plain string to avoid early text domain loading
 						printf(
 							/* translators: dependency not ready error message */
-							esc_html__( '%1$s must be active for WPGraphQL Plugin Name to work.', 'wp-graphql-headless-webhooks' ),
+							'%1$s must be active for WPGraphQL Headless Webhooks to work.',
 							esc_html( $dep )
 						);
 						?>
@@ -130,6 +139,20 @@ static function () use ($dep) {
 		);
 	}
 }
+/**
+ * Load plugin text domain.
+ */
+function graphql_headless_webhooks_load_textdomain(): void {
+	load_plugin_textdomain(
+		'wp-graphql-headless-webhooks',
+		false,
+		dirname( plugin_basename( __FILE__ ) ) . '/languages'
+	);
+}
+
+// Load the text domain during init, not earlier
+add_action( 'init', 'WPGraphQL\Webhooks\graphql_headless_webhooks_load_textdomain', 1 );
+
 /** @psalm-suppress HookNotFound */
 add_action( 'plugins_loaded', 'WPGraphQL\Webhooks\graphql_headless_webhooks_init' );