Skip to content

chore: DRAFT - Updating e2e tests to use pnpm. #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
colinmurphy merged 6 commits into from
Jul 9, 2025
Merged

chore: DRAFT - Updating e2e tests to use pnpm. #332

colinmurphy merged 6 commits into from
Jul 9, 2025

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented Jul 8, 2025 •
edited
Loading

Description

  1. Removes npm
  2. Updates pnpm packages
  3. Updates e2e workflow to use pnpm (WIP)

Note

I updated @wordpress/scripts to use version as 30.18 as there is a bug with the latest version - WordPress/gutenberg#70549

Related Issue

Fixes #331

Dependant PRs

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Screenshots

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 026989b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

github-actions bot commented Jul 8, 2025 •
edited
Loading

ℹ️ Download the latest hwp-previews plugin zip from this PR
(See the 'Artifacts' section at the bottom)

@colinmurphy colinmurphy marked this pull request as ready for review July 9, 2025 12:22
@colinmurphy colinmurphy requested a review from a team as a code owner July 9, 2025 12:22
@colinmurphy colinmurphy enabled auto-merge July 9, 2025 12:23
@colinmurphy colinmurphy added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit e8bd4f2 Jul 9, 2025
15 checks passed
@colinmurphy colinmurphy deleted the chore-remove-npm-for-e2e branch July 9, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theodesp theodesp theodesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore: Use PNPM instead of NPM for e2e workflow

3 participants

@colinmurphy @theodesp