Ending support of PHP 5.2 (#273)

* Removed post-update-cmd and post-install-cmd from composer file.

* Removed composer.json and composer.lock file from php52 directory.

* removes 5.2 support

* Removed references to php52.

* Replaced old test boostrap with modern one.

* Removed phpunit phpunit6-compat.php file. No longer needed.

* Removed old php versions from list. No longer needed.

* Pinned squizlabs/php_codesniffer to version 2.9.2 until support for php 7.4 can be implemented.

* Removed php version conditional for vendor/autoload.php include.

Co-authored-by: Ryan Meier <[email protected]>
Co-authored-by: Anthony Burchell <[email protected]>

Author: 3 people

.distignore

@@ -1,4 +1,3 @@
-+ php52/vendor/bin
 + vendor/bin
 - bin
 .circleci

build.sh

@@ -20,8 +20,6 @@ rsync \
 	--include="src/**" \
 	--include='vendor' \
 	--include='vendor/**' \
-	--include='php52' \
-	--include='php52/**' \
 	--exclude="*" \
 	./ ./build/trunk
 

composer.json

@@ -7,21 +7,15 @@
 		"email": "[email protected]"
 	}],
 	"require": {
-		"squizlabs/php_codesniffer": "^2.9.2",
 		"dealerdirect/phpcodesniffer-composer-installer": "^0.4.4",
-		"phpcompatibility/phpcompatibility-wp": "^2"
+		"phpcompatibility/phpcompatibility-wp": "^2",
+		"squizlabs/php_codesniffer": "2.9.2"
 	},
 	"require-dev": {
 		"wp-coding-standards/wpcs": "^1",
 		"phpunit/phpunit": "^5"
 	},
 	"scripts": {
-		"post-update-cmd": [
-			"cd php52; composer update; cd .."
-		],
-		"post-install-cmd": [
-			"cd php52; composer install; cd .."
-		],
 		"phpcs": "phpcs --standard=src/ruleset-wordpress.xml wpengine-phpcompat.php load-files.php src/*.php",
 		"phpcs:fix": "phpcbf --standard=src/ruleset-wordpress.xml wpengine-phpcompat.php load-files.php src/*.php",
 		"test": "phpunit"

composer.lock

@@ -16,14 +16,7 @@
  */
 function wpephpcompat_load_files() {
 	require_once dirname( __FILE__ ) . '/src/wpephpcompat.php';
-
-	if ( version_compare( phpversion(), '5.3', '<' ) ) {
-		$autoload_file = dirname( __FILE__ ) . '/php52/vendor/autoload_52.php';
-	} else {
-		$autoload_file = dirname( __FILE__ ) . '/vendor/autoload.php';
-	}
-
-	require_once $autoload_file;
+	require_once dirname( __FILE__ ) . '/vendor/autoload.php';
 
 	if ( defined( 'WP_CLI' ) && WP_CLI ) {
 		require_once dirname( __FILE__ ) . '/src/wpcli.php';

load-files.php

@@ -1,3 +1,3 @@
 #!/bin/bash
 
-find . -not \( -path ./vendor -prune \) -not \( -path ./php52 -prune \) -type f -name '*.php' -print0 | xargs -0 -n1 -P4 -I {} php -l -n {} | (! grep -v "No syntax errors detected" )
+find . -not \( -path ./vendor -prune \) -type f -name '*.php' -print0 | xargs -0 -n1 -P4 -I {} php -l -n {} | (! grep -v "No syntax errors detected" )

php-lint.sh

@@ -1,41 +1,31 @@
 <?php
+/**
+ * PHPUnit bootstrap file
+ *
+ * @package Sample_Plugin
+ */
 
-// Disable xdebug backtrace.
-if ( function_exists( 'xdebug_disable' ) ) {
-	xdebug_disable();
-}
+$_tests_dir = getenv( 'WP_TESTS_DIR' );
 
-if ( false !== getenv( 'WP_PLUGIN_DIR' ) ) {
-	define( 'WP_PLUGIN_DIR', getenv( 'WP_PLUGIN_DIR' ) );
+if ( ! $_tests_dir ) {
+	$_tests_dir = rtrim( sys_get_temp_dir(), '/\\' ) . '/wordpress-tests-lib';
 }
 
-$GLOBALS['wp_tests_options'] = array(
-	'active_plugins' => array( basename( dirname( dirname( dirname( __FILE__ ) ) ) ) . '/wpengine-phpcompat.php' ),
-);
-
-if ( false !== getenv( 'WP_DEVELOP_DIR' ) ) {
-	$test_root = getenv( 'WP_DEVELOP_DIR' ) . '/tests/phpunit';
-} elseif ( file_exists( '/tmp/wordpress-tests-lib/includes/bootstrap.php' ) ) {
-	$test_root = '/tmp/wordpress-tests-lib';
-} else {
-	$test_root = '../../../../../../../tests/phpunit';
+if ( ! file_exists( $_tests_dir . '/includes/functions.php' ) ) {
+	echo "Could not find $_tests_dir/includes/functions.php, have you run bin/install-wp-tests.sh ?" . PHP_EOL; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
+	exit( 1 );
 }
 
-if ( file_exists( $test_root . '/includes/functions.php' ) ) {
-	require_once $test_root . '/includes/functions.php';
-	function _manually_load_plugin() {
-		require dirname( __FILE__ ) . '/../../wpengine-phpcompat.php';
-	}
-
-	tests_add_filter( 'muplugins_loaded', '_manually_load_plugin' );
-}
+// Give access to tests_add_filter() function.
+require_once $_tests_dir . '/includes/functions.php';
 
-// Core started including their own phpunit6-compat, so we should use that if we can.
-if ( ! file_exists( $test_root . '/includes/phpunit6/compat.php' ) ) {
-	// WordPress versions before 4.8 will be incompatible with newer PHPUnit versions.
-	if ( version_compare( getenv( 'WP_VERSION' ), '4.8', '<' ) && class_exists( 'PHPUnit\Runner\Version' ) ) {
-		require_once dirname( __FILE__ ) . '/phpunit6-compat.php';
-	}
+tests_add_filter( 'muplugins_loaded', '_manually_load_plugin' );
+/**
+ * Manually load the plugin being tested.
+ */
+function _manually_load_plugin() {
+	require dirname( dirname( dirname( __FILE__ ) ) ) . '/wpengine-phpcompat.php';
 }
 
-require $test_root . '/includes/bootstrap.php';
+// Start up the WP testing environment.
+require $_tests_dir . '/includes/bootstrap.php';