Merge pull request #91 from octalmage/whitelist-updates

Whitelist updates.

Author: octalmage

src/wpephpcompat.php

@@ -75,6 +75,15 @@ class WPEPHPCompat {
 		'*/tablepress/*' => '7.0',
 		'*/myMail/*' => '7.0',
 		'*/wp-spamshield/*' => '7.0',
+		'*/vendor/stripe/stripe-php/lib/StripeObject.php' => '7.0', // https://github.com/wpengine/phpcompat/issues/89
+		'*/gravityforms/*' => '7.0', // https://github.com/wpengine/phpcompat/issues/85
+		'*/download-monitor/*' => '7.0', // https://github.com/wpengine/phpcompat/issues/84
+		'*/query-monitor/*' => '7.0', // https://wordpress.org/support/topic/false-positive-showing-query-monitor-as-not-php-7-compatible/
+		'*/bbpress/*' => '7.0', // https://wordpress.org/support/topic/false-positive-showing-bbpress-as-not-php-7-compatible/
+		'*/comet-cache/*' => '7.0', // https://wordpress.org/support/topic/false-positive-comet-cache/
+		'*/comment-mail/*' => '7.0', // https://wordpress.org/support/topic/false-positive-comment-mail/
+		'*/social-networks-auto-poster-facebook-twitter-g/*' => '7.0', // https://wordpress.org/plugins/social-networks-auto-poster-facebook-twitter-g/
+		'*/mailpoet/*' => '7.0', // https://wordpress.org/support/topic/false-positive-mailpoet-3-not-compatible-with-php7/
 	);
 
 	/**
@@ -293,7 +302,7 @@ public function generate_ignored_list() {
 			}
 		}
 
-		return $ignored;
+		return apply_filters( 'phpcompat_whitelist', $ignored );
 	}
 
 	/**

tests/phpunit/test_generate_ignored_list.php

@@ -70,4 +70,14 @@ function test_generate_ignored_list_version_55() {
 		$this->assertNotContains( '*/fakeplugin/*', $ignored );
 		$this->assertNotContains( '*/oldplugin/*', $ignored );
 	}
+
+	function test_filter_ignored_list() {
+		tests_add_filter( 'phpcompat_whitelist', function( $whitelist ) {
+			return array_merge( $whitelist, array( '*/filterplugin/*') );
+		} );
+
+		$ignored = $this->wpephpc->generate_ignored_list();
+		
+		$this->assertContains( '*/filterplugin/*', $ignored );
+	}
 }

tests/phpunit/test_scan.php

@@ -2,11 +2,6 @@
 class TestScan extends WP_UnitTestCase {
 
 	function test_scan_default_PHP_55() {
-		$expected_results = "Name: Twenty Sixteen
-
-PHP 5.5 compatible.
-
-";
 		$root_dir = realpath( __DIR__ . '/../../' );
 
 		$wpephpc = new \WPEPHPCompat( $root_dir );
@@ -19,15 +14,10 @@ function test_scan_default_PHP_55() {
 
 		$results = $wpephpc->start_test();
 
-		$this->assertEquals( $expected_results, $results );
+		$this->assertContains( 'PHP 5.5 compatible.', $results );
 	}
 
 	function test_scan_default_PHP_70() {
-		$expected_results = "Name: Twenty Sixteen
-
-PHP 7.0 compatible.
-
-";
 		$root_dir = realpath( __DIR__ . '/../../' );
 
 		$wpephpc = new \WPEPHPCompat( $root_dir );
@@ -40,6 +30,6 @@ function test_scan_default_PHP_70() {
 
 		$results = $wpephpc->start_test();
 
-		$this->assertEquals( $expected_results, $results );
+		$this->assertContains( 'PHP 7.0 compatible.', $results );
 	}
 }