Skip to content

Commit dbddffd

Browse files
committed
Update text in UI for clarity
Changed wording to be “potentially” incompatible rather than being binary yes or no.
1 parent 1d3af74 commit dbddffd

File tree

1 file changed

+17
-7
lines changed

1 file changed

+17
-7
lines changed

wpengine-phpcompat.php

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Plugin URI: https://wpengine.com
55
Description: Make sure your plugins and themes are compatible with newer PHP versions.
66
Author: WP Engine
7-
Version: 1.2.4
7+
Version: 1.3
88
Author URI: https://wpengine.com
99
Text Domain: php-compatibility-checker
1010
*/
@@ -200,12 +200,12 @@ function admin_enqueue( $hook ) {
200200
$strings = array(
201201
'name' => __( 'Name', 'php-compatibility-checker' ),
202202
'compatible' => __( 'compatible', 'php-compatibility-checker' ),
203-
'are_not' => __( 'plugins/themes are not compatible', 'php-compatibility-checker' ),
204-
'is_not' => __( 'Your WordPress install is not PHP', 'php-compatibility-checker' ),
203+
'are_not' => __( 'plugins/themes are possibly not compatible', 'php-compatibility-checker' ),
204+
'is_not' => __( 'Your WordPress site is possibly not PHP', 'php-compatibility-checker' ),
205205
'out_of' => __( 'out of', 'php-compatibility-checker' ),
206206
'run' => __( 'Run', 'php-compatibility-checker' ),
207207
'rerun' => __( 'Re-run', 'php-compatibility-checker' ),
208-
'your_wp' => __( 'Your WordPress install is', 'php-compatibility-checker' ),
208+
'your_wp' => __( 'Your WordPress site is', 'php-compatibility-checker' ),
209209
);
210210

211211
wp_localize_script( 'wpephpcompat', 'wpephpcompat', $strings );
@@ -245,7 +245,16 @@ function settings_page() {
245245
<div style="float: right; margin-top: 10px; text-align: right;">
246246
<input type="checkbox" id="developermode" name="developermode" value="yes" /><?php esc_attr_e( 'Developer mode', 'php-compatibility-checker' ); ?>
247247
</div>
248-
<br><br>
248+
<div class="clear">
249+
<p><?php esc_attr_e( 'This plugin will lint theme and plugin code inside your WordPress file system and give you back a report of compatibility issues for you to fix. Compatibility issues are categorized into errors and warnings and will list the file and line number of the offending code, as well as the info about why that line of code is incompatible with the chosen version of PHP. The plugin will also suggest updates to themes and plugins, as a new version may offer compatible code.', 'php-compatibility-checker' ); ?></p>
250+
<p><b><?php esc_attr_e( 'This plugin does not execute your theme and plugin code, as such this plugin cannot detect runtime compatibility issues.', 'php-compatibility-checker' ); ?></b></p>
251+
252+
253+
<p><?php printf( __('Please note that linting code is not perfect. This plugin cannot detect unused code paths that might be used for backwards compatibility, and thus might show false positives. You can <a href="%1$s">report false positives on our GitHub repo</a>.', 'php-compatibility-checker'), "https://github.com/wpengine/phpcompat/wiki/Results" ); ?></p>
254+
255+
<p><?php printf( __('This plugin relies on WP-Cron to scan files in the background. The scan will get stuck if the site&#39s WP-Cron is not running correctly. Please <a href="%1$s">see the FAQ</a> for more information.', 'php-compatibility-checker'), "https://wordpress.org/plugins/php-compatibility-checker/faq/" ); ?></p>
256+
</div>
257+
<hr>
249258
<h3 class="title clear"><?php esc_attr_e( 'Scan Options', 'php-compatibility-checker' ); ?></h3>
250259
<table class="form-table">
251260
<tbody>
@@ -267,6 +276,7 @@ function settings_page() {
267276
</tr>
268277
</tbody>
269278
</table>
279+
<hr />
270280
<p>
271281
<div style="display: none;" id="wpe-progress">
272282
<label for=""><?php esc_attr_e( 'Progress', 'php-compatibility-checker' ); ?></label>
@@ -285,7 +295,7 @@ function settings_page() {
285295
</div>
286296

287297
<div id="footer" style="display: none;">
288-
<?php esc_attr_e( 'Note: Warnings are not currently an issue, but they could be in the future.', 'php-compatibility-checker' ); ?><br>
298+
<?php esc_attr_e( 'Note: PHP Warnings will not cause errors, but could cause compatibility issues with future PHP versions, and could spam your PHP logs.', 'php-compatibility-checker' ); ?><br>
289299
<a id="downloadReport" href="#"><?php esc_attr_e( 'Download Report', 'php-compatibility-checker' ); ?></a>
290300
</div>
291301
</p>
@@ -303,7 +313,7 @@ function settings_page() {
303313
</div>
304314
<div class="inner-right">
305315
<h3 style="margin: 0px;">{{plugin_name}}</h3>
306-
{{#if skipped}}<?php esc_attr_e( 'Unknown', 'php-compatibility-checker' ); ?>{{else if passed}}PHP {{test_version}} <?php esc_attr_e( 'compatible', 'php-compatibility-checker' ); ?>.{{else}}<b><?php esc_attr_e( 'Not', 'php-compatibility-checker' ); ?></b> PHP {{test_version}} <?php esc_attr_e( 'compatible', 'php-compatibility-checker' ); ?>.{{/if}}<br>
316+
{{#if skipped}}<?php esc_attr_e( 'Unknown', 'php-compatibility-checker' ); ?>{{else if passed}}PHP {{test_version}} <?php esc_attr_e( 'compatible', 'php-compatibility-checker' ); ?>.{{else}}<b><?php esc_attr_e( 'Possibly not', 'php-compatibility-checker' ); ?></b> PHP {{test_version}} <?php esc_attr_e( 'compatible', 'php-compatibility-checker' ); ?>.{{/if}}<br>
307317
{{update}}<br>
308318
<textarea style="display: none; white-space: pre;">{{logs}}</textarea><a class="view-details"><?php esc_attr_e( 'view details', 'php-compatibility-checker' ); ?></a>
309319
</div>

0 commit comments

Comments
 (0)