Working on build script and local dev.

Author: octalmage

Dockerfile

@@ -0,0 +1,32 @@
+# Start with the latest WordPress image.
+FROM wordpress:4.9.1-php7.0-apache
+
+# Set up nodejs PPA
+RUN curl -sL https://deb.nodesource.com/setup_6.x | bash
+
+# Install server dependencies.
+RUN apt-get update && apt-get install -qq -y nodejs build-essential pkg-config libcairo2-dev libjpeg-dev libgif-dev git subversion mysql-client zip unzip vim libyaml-dev --fix-missing --no-install-recommends
+
+# Setup phpunit dependencies (needed for coverage) and yaml (needed for contract tests).
+RUN pecl install xdebug && \
+		docker-php-ext-enable xdebug
+
+COPY tests/install-wp-tests.sh /
+RUN /install-wp-tests.sh wordpress root password mysql 4.9.1 true
+
+# Download wp-cli
+RUN curl -o /usr/local/bin/wp https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli.phar && chmod 755 /usr/local/bin/wp
+
+# Speed up phpcs https://stackoverflow.com/questions/37450185/php-code-sniffer-via-grunt-is-incredibly-slow
+RUN echo "default_socket_timeout = 5\nlog_errors = On\nerror_log = /dev/stderr" > /usr/local/etc/php/php.ini
+
+# Disable PHP opcache (not great while developing)
+RUN rm -rf /usr/local/etc/php/conf.d/opcache-recommended.ini
+
+# Install composer.
+COPY --from=composer:latest /usr/bin/composer /usr/bin/composer
+
+RUN composer global require "phpunit/phpunit:^6"
+
+ENV PATH="/root/.composer/vendor/bin:${PATH}"
+ENV WP_VERSION="4.9.1"

Makefile

@@ -0,0 +1,12 @@
+SHELL := /bin/bash
+
+# WordPress management via docker-compose
+start:
+	docker-compose -f docker-compose.yml up -d
+
+stop:
+	docker-compose -f docker-compose.yml stop
+
+# One liner to get a shell inside the WordPress container.
+shell:
+	docker-compose exec wordpress /bin/bash -c "cd /var/www/html/wp-content/plugins/phpcompat/; /bin/bash"

build.sh

@@ -0,0 +1,32 @@
+!/bin/bash
+if [ ! -d "build" ]; then
+  svn co https://plugins.svn.wordpress.org/php-compatibility-checker build
+else
+	pushd build
+	svn up
+	popd
+fi
+
+composer install --no-dev
+rsync \
+	-avuP \
+  --delete \
+  --exclude="Tests" \
+  --include='wpengine-phpcompat.php' \
+  --include='uninstall.php' \
+  --include='load-files.php' \
+  --include='readme.txt' \
+  --include='src' \
+  --include="src/**" \
+  --include='vendor' \
+  --include='vendor/**' \
+  --include='php52' \
+  --include='php52/**' \
+  --exclude="*" \
+	./ ./build/trunk
+
+pushd ./build/trunk
+zip -r phpcompat.zip .
+popd
+rm ./phpcompat.zip
+mv ./build/trunk/phpcompat.zip ./

composer.json

@@ -9,7 +9,7 @@
 	"require": {
 		"squizlabs/php_codesniffer": "^2.9.1",
 		"dealerdirect/phpcodesniffer-composer-installer": "^0.4.4",
-		"phpcompatibility/php-compatibility": "^8"
+		"phpcompatibility/phpcompatibility-wp": "^1"
 	},
 	"require-dev": {
 		"wp-coding-standards/wpcs": "dev-master"

composer.lock

@@ -0,0 +1,22 @@
+version: '2'
+services:
+  wordpress:
+    build: .
+    image: phpcompat/plugin
+    restart: always
+    depends_on:
+      - db
+    links:
+    - db:mysql
+    ports:
+      - 8081:80
+    volumes:
+      - ./:/var/www/html/wp-content/plugins/phpcompat
+    environment:
+      WORDPRESS_DB_PASSWORD: password
+  db:
+    image: mysql
+    restart: always
+    environment:
+      - MYSQL_ROOT_PASSWORD=password
+      - MYSQL_DATABASE=wordpress

docker-compose.yml

@@ -58,6 +58,14 @@ jQuery( document ).ready(function($) {
 	});
 
 });
+
+function startTimer() {
+	// Requeue the checkStatus call.
+	timer = setTimeout(function() {
+		checkStatus();
+	}, 5000);
+}
+
 /**
  * Check the scan status and display results if scan is done.
  */
@@ -68,6 +76,10 @@ function checkStatus() {
 
 	var obj;
 	jQuery.post( ajaxurl, data, function( obj ) {
+		if ( !obj ) {
+			startTimer();
+			return;
+		}
 		/*
 		 * Status false: the test is not running and has not been run yet
 		 * Status 1: the test is currently running
@@ -101,10 +113,7 @@ function checkStatus() {
 			// Display the object being scanned.
 			jQuery( '#wpe-progress-active' ).html( '<strong>Now scanning:</strong> ' + obj.activeJob );
 
-			// Requeue the checkStatus call.
-			timer = setTimeout(function() {
-				checkStatus();
-			}, 5000);
+			startTimer();
 		}
 	}, 'json' ).fail(function ( xhr, status, error )
 	{

src/js/run.js

@@ -91,6 +91,7 @@ class WPEPHPCompat {
 		'*/give/*'                                        => '7.0', // https://github.com/wpengine/phpcompat/issues/148
 		'*/woocommerce-pdf-invoices-packing-slips/*'      => '7.0', // https://github.com/wpengine/phpcompat/issues/160
 		'*/iwp-client/*'                                  => '7.0', // https://wordpress.org/support/topic/iwp-client-and-php-7-compatibility/
+		'*/health-check/*'                                => '7.2', // https://github.com/wpengine/phpcompat/issues/179
 	);
 
 	/**

src/wpephpcompat.php

@@ -148,6 +148,27 @@ QUnit.test( 'Test checkStatus done', function( assert ) {
 	checkStatus();
 });
 
+QUnit.test( 'Test checkStatus empty result', function( assert ) {
+	var done = assert.async();
+	var fixture = $( '#qunit-fixture' );
+	fixture.append( '<div id="wpe-progress"><div id="wpe-pcc-progress-count"></div></div>' );
+
+	ajaxurl = '/checkStatus/empty/';
+
+	$.mockjax({
+		url: ajaxurl,
+		responseTime: 0,
+		responseText: '',
+		onAfterComplete: function() {
+			assert.ok(true, 'Empty responseText does not throw an error.');
+			clearTimeout( timer );
+			done();
+		}
+	});
+
+	checkStatus();
+});
+
 QUnit.test( 'Test checkStatus fail JSON.parse', function( assert ) {
 	var done = assert.async();
 	var fixture = $( '#qunit-fixture' );