Skip to content

Commit 01d51ec

Browse files
authored
Remove references to the "old" PIDController (#2288)
1 parent 4587402 commit 01d51ec

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

source/docs/software/advanced-controls/controllers/combining-feedforward-feedback.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Feedforward and feedback controllers can each be used in isolation, but are most
1212
Using Feedforward with a PIDController
1313
--------------------------------------
1414

15-
Users familiar with the old ``PIDController`` class may notice the lack of any feedforward gain in the new controller. As users are expected to use the controller output themselves, there is no longer any need for the ``PIDController`` to implement feedforward - users may simply add any feedforward they like to the output of the controller before sending it to their motors:
15+
Users may add any feedforward they like to the output of the controller before sending it to their motors:
1616

1717
.. tabs::
1818

source/docs/software/advanced-controls/controllers/pidcontroller.rst

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ WPILib supports PID control of mechanisms through the ``PIDController`` class (`
1010
Using the PIDController Class
1111
-----------------------------
1212

13-
.. note:: The ``PIDController`` class in the ``frc`` namespace is deprecated - C++ teams should use the one in the ``frc2`` namespace, instead. Likewise, Java teams should use the class in the ``edu.wpi.first.math.controller`` package.
14-
1513
Constructing a PIDController
1614
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1715

@@ -38,8 +36,6 @@ Using the Feedback Loop Output
3836

3937
.. note:: The ``PIDController`` assumes that the ``calculate()`` method is being called regularly at an interval consistent with the configured period. Failure to do this will result in unintended loop behavior.
4038

41-
.. warning:: Unlike the old ``PIDController``, the new PIDController does not automatically control an output from its own thread - users are required to call ``calculate()`` and use the resulting output in their own code.
42-
4339
Using the constructed ``PIDController`` is simple: simply call the ``calculate()`` method from the robot's main loop (e.g. the robot's ``autonomousPeriodic()`` method):
4440

4541
.. tabs::
@@ -181,8 +177,6 @@ To configure a ``PIDController`` to automatically do this, use the ``enableConti
181177
Clamping Controller Output
182178
--------------------------
183179

184-
Unlike the old ``PIDController``, the new controller does not offer any output clamping features, as the user is expected to use the loop output themselves. Output clamping can be easily achieved by composing the controller with WPI's ``clamp()`` function (or ``std::clamp`` in c++):
185-
186180
.. tabs::
187181

188182
.. code-tab:: java

0 commit comments

Comments
 (0)