Use @staticmethod where methods are static

Author: modelmat

wpiformat/wpiformat/bracecomment.py

@@ -9,7 +9,8 @@
 
 class BraceComment(Task):
 
-    def should_process_file(self, config_file, name):
+    @staticmethod
+    def should_process_file(config_file, name):
         return config_file.is_c_file(name) or config_file.is_cpp_file(name)
 
     def run_pipeline(self, config_file, name, lines):

wpiformat/wpiformat/cidentlist.py

@@ -7,12 +7,14 @@
 
 class CIdentList(Task):
 
-    def __print_failure(self, name):
+    @staticmethod
+    def __print_failure(name):
         print("Error: " + name + ": unmatched curly braces when scanning for "
               "C identifier lists. If the code compiles, this is a bug in "
               "wpiformat.")
 
-    def should_process_file(self, config_file, name):
+    @staticmethod
+    def should_process_file(config_file, name):
         return config_file.is_c_file(name) or config_file.is_cpp_file(name)
 
     def run_pipeline(self, config_file, name, lines):

wpiformat/wpiformat/clangformat.py

@@ -22,7 +22,8 @@ def __init__(self, clang_version):
         else:
             self.exec_name = "clang-format-" + clang_version
 
-    def should_process_file(self, config_file, name):
+    @staticmethod
+    def should_process_file(config_file, name):
         return config_file.is_c_file(name) or config_file.is_cpp_file(name)
 
     def run_pipeline(self, config_file, name, lines):

wpiformat/wpiformat/config.py

@@ -101,7 +101,8 @@ def is_c_header_file(self, name):
         """
         return self.__c_header_include_regex.search(name) is not None
 
-    def is_c_src_file(self, name):
+    @staticmethod
+    def is_c_src_file(name):
         """Returns True if file is C source file.
 
         Keyword arguments:

wpiformat/wpiformat/includeguard.py

@@ -17,7 +17,8 @@ class State(Enum):
 
 class IncludeGuard(Task):
 
-    def should_process_file(self, config_file, name):
+    @staticmethod
+    def should_process_file(config_file, name):
         return config_file.is_header_file(name)
 
     def run_pipeline(self, config_file, name, lines):

wpiformat/wpiformat/includeorder.py

@@ -69,7 +69,8 @@ def __init__(self):
                                           r"(?P<close_bracket>>|\"))"
                                           r"(?P<postfix>.*)$")
 
-    def should_process_file(self, config_file, name):
+    @staticmethod
+    def should_process_file(config_file, name):
         return config_file.is_c_file(name) or config_file.is_cpp_file(name)
 
     def classify_header(self, config_file, include_line, file_name):
@@ -112,7 +113,8 @@ def classify_header(self, config_file, include_line, file_name):
         else:
             return -1
 
-    def include_is_header(self, config_file, file_name, include_name):
+    @staticmethod
+    def include_is_header(config_file, file_name, include_name):
         """Return True if include name has header extension.
 
         Keyword arguments:
@@ -129,7 +131,8 @@ def include_is_header(self, config_file, file_name, include_name):
         else:
             return True
 
-    def rebuild_include(self, name_match, group_number):
+    @staticmethod
+    def rebuild_include(name_match, group_number):
         """Adds appropriate brackets around include name and "#include" before
         that based on group number.
 
@@ -151,7 +154,8 @@ def rebuild_include(self, name_match, group_number):
         else:
             return output
 
-    def dedup_list(self, seq):
+    @staticmethod
+    def dedup_list(seq):
         """Remove duplicates from list while preserving order.
 
         Keyword arguments:

wpiformat/wpiformat/javaclass.py

@@ -7,7 +7,8 @@
 
 class JavaClass(Task):
 
-    def should_process_file(self, config_file, name):
+    @staticmethod
+    def should_process_file(config_file, name):
         return name.endswith(".java")
 
     def run_pipeline(self, config_file, name, lines):

wpiformat/wpiformat/jni.py

@@ -26,10 +26,12 @@
 
 class Jni(Task):
 
-    def should_process_file(self, config_file, name):
+    @staticmethod
+    def should_process_file(config_file, name):
         return config_file.is_cpp_src_file(name)
 
-    def map_jni_type(self, type_name):
+    @staticmethod
+    def map_jni_type(type_name):
         ret = ""
         if type_name.endswith("*") or type_name.endswith("Array"):
             ret += "["

wpiformat/wpiformat/licenseupdate.py

@@ -12,7 +12,8 @@
 
 class LicenseUpdate(Task):
 
-    def should_process_file(self, config_file, name):
+    @staticmethod
+    def should_process_file(config_file, name):
         license_regex = config_file.regex("licenseUpdateExclude")
 
         return (config_file.is_c_file(name) or config_file.is_cpp_file(name) or

wpiformat/wpiformat/lint.py

@@ -17,10 +17,12 @@
 
 class Lint(Task):
 
-    def should_process_file(self, config_file, name):
+    @staticmethod
+    def should_process_file(config_file, name):
         return config_file.is_cpp_file(name)
 
-    def run_batch(self, config_file, names):
+    @staticmethod
+    def run_batch(config_file, names):
         # Handle running in either the root or styleguide directories
         cpplintPrefix = ""
         if os.getcwd().rpartition(os.sep)[2] != "styleguide":