Addressed review comments

Author: alan412

external_samples/port.py

@@ -25,13 +25,13 @@ class PortType(Enum):
     SERVO_PORT = 4
     I2C_PORT = 5
     USB_PORT = 6
-    EXPANSION_HUB_MOTOR_PORT = 7
-    EXPANSION_HUB_SERVO_PORT = 8
+    EXPANSION_HUB_MOTOR_PORT = 7  # This is the port on the expansion hub
+    EXPANSION_HUB_SERVO_PORT = 8  # This is the port on the expansion hub
 
     BASE_COMPOUND = 256
     USB_HUB = BASE_COMPOUND + 1
-    EXPANSION_HUB_MOTOR = BASE_COMPOUND + 2
-    EXPANSION_HUB_SERVO = BASE_COMPOUND + 3
+    EXPANSION_HUB_MOTOR = BASE_COMPOUND + 2   # This is combination expansion hub and motor
+    EXPANSION_HUB_SERVO = BASE_COMPOUND + 3   # This is combination expansion hub and servo
 
 class Port:
     def __init__(self, port_type: PortType = None, location: int = None, port1: type[Self] = None, port2: type[Self] = None):

external_samples/rev_touch_sensor.py

@@ -45,9 +45,6 @@ def reset(self) -> None:
         self.released_callback = None
         pass
 
-    def get_connection_port_type(self) -> PortType | None:
-        return self.port.get_type
-
     def periodic(self) -> None:
         old = self.is_pressed
         self._read_hardware()

external_samples/smart_motor.py

@@ -46,9 +46,6 @@ def stop(self) -> None:
     def reset(self) -> None:
         pass
 
-    def get_connection_port_type(self) -> PortType | None:
-        return self.port.get_type()
-
     def periodic(self) -> None:
         pass
 

python_tools/json_util.py

@@ -360,7 +360,6 @@ def _processClass(self, cls):
         constructor_data[_KEY_FUNCTION_ARGS] = args
         constructor_data[_KEY_FUNCTION_DECLARING_CLASS_NAME] = declaring_class_name
         constructor_data[_KEY_FUNCTION_RETURN_TYPE] = declaring_class_name
-        # This is where I check to see if
         expectedPortType = python_util.getPortTypeFromConstructor(value)
         if expectedPortType:
           constructor_data[_KEY_PORT_EXPECTED_TYPE] = python_util.getPortTypeFromConstructor(value)