Address review comments

Author: alan412

src/blocks/mrc_port.ts

@@ -100,7 +100,7 @@ const PORT = {
       const port = this.ports_[i];
       this.appendDummyInput('PORT_' + i)
         .appendField(createFieldNonEditableText(port.portType), 'TYPE_' + i)
-        .appendField(createFieldDropdownForPortType(port.portType, port.portNumber), 'PORT_' + i)
+        .appendField(createFieldDropdownForPortType(port.portType, port.portNumber), 'PORT_NUM_' + i)
         .setAlign(Blockly.inputs.Align.RIGHT);
     }
   },
@@ -157,31 +157,31 @@ export const pythonFromBlock = function (
   return [code, Order.ATOMIC];
 }
 
-function createFieldDropdownForPortType( portType : string, defaultVal : number) : Blockly.Field {
-  switch(portType){
+function createFieldDropdownForPortType(portType: string, defaultVal: number): Blockly.Field {
+  switch (portType) {
     case 'can':
-      return createFieldNumberDropdown(0, 4, 1, defaultVal);
+      return createFieldNumberDropdown(0, 4, defaultVal);
     case 'smartio':
-      return createFieldNumberDropdown(0, 5, 1, defaultVal);
+      return createFieldNumberDropdown(0, 5, defaultVal);
     case 'MotionCore port':
-      return createFieldNumberDropdown(1, 6, 1, defaultVal);
+      return createFieldNumberDropdown(1, 6, defaultVal);
     case 'i2c':
-      return createFieldNumberDropdown(0, 1, 1, defaultVal);
+      return createFieldNumberDropdown(0, 1, defaultVal);
     case 'usb in':
-      return createFieldNumberDropdown(0, 3, 1, defaultVal);
+      return createFieldNumberDropdown(0, 3, defaultVal);
     case 'motor':
-      return createFieldNumberDropdown(1, 6, 1, defaultVal);
+      return createFieldNumberDropdown(1, 6, defaultVal);
     case 'servo':
-      return createFieldNumberDropdown(1, 6, 1, defaultVal);
+      return createFieldNumberDropdown(1, 6, defaultVal);
     default:
-      return createFieldNumberDropdown(0, 99, 1, defaultVal);
+      return createFieldNumberDropdown(0, 99, defaultVal);
   }
 }
 
-export function createPort(portType : string) {
+export function createPort(portType: string) {
   // Based off of the port type, create the right number and type of ports
-  const ports : MrcPortType[] = [];
-  switch(portType){
+  const ports: MrcPortType[] = [];
+  switch (portType) {
     case 'CAN_PORT':
       ports.push({ portType: 'can', portNumber: 1 });
       break;

src/fields/field_number_dropdown.ts

@@ -23,9 +23,9 @@
 import * as Blockly from 'blockly/core';
 import { createFieldDropdown } from './FieldDropdown';
 
-export function createFieldNumberDropdown(min : number, max : number, precision : number, defaultVal : number): Blockly.Field {
+export function createFieldNumberDropdown(min: number, max: number, defaultVal: number): Blockly.Field {
   const items: string[] = [];
-  for (let i = min; i <= max; i += precision) {
+  for (let i = min; i <= max; i++) {
     items.push(i.toString());
   }
   const field = createFieldDropdown(items);