Skip to content

Commit 2c0dabc

Browse files
committed
Don't allow user to override define_hardware in the robot.
1 parent edf4679 commit 2c0dabc

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/toolbox/methods_category.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,14 @@ export class MethodsCategory {
6363
switch (editor.getCurrentModuleType()) {
6464
case commonStorage.MODULE_TYPE_ROBOT:
6565
// TODO(lizlooney): We need a way to mark a method in python as not overridable.
66-
// For example, in RobotBase, register_event_handler, unregister_event_handler,
67-
// and fire_event should not be overridden in a user's robot.
66+
// For example, in RobotBase, define_hardware, register_event_handler,
67+
// unregister_event_handler, and fire_event should not be overridden in a user's robot.
6868
const methodNamesNotOverrideable: string[] = [
69+
'define_hardware',
70+
'fire_event',
71+
'register_event_handler',
6972
'register_event_handler',
7073
'unregister_event_handler',
71-
'fire_event',
7274
];
7375
// Add the methods for a Robot.
7476
this.addClassBlocksForCurrentModule(

0 commit comments

Comments
 (0)