Skip to content

Commit 632acf1

Browse files
authored
Change to semantic versioning (#107)
1 parent 0ca88a9 commit 632acf1

File tree

6 files changed

+14
-15
lines changed

6 files changed

+14
-15
lines changed

external_samples/color_range_sensor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ def get_part_number(self) -> str:
4040
return "REV-31-1557"
4141
def get_url(self) -> str:
4242
return "https://www.revrobotics.com/rev-31-1557"
43-
def get_version(self) -> tuple[int, int, str]:
44-
return (1, 0, "")
43+
def get_version(self) -> tuple[int, int, int]:
44+
return (1, 0, 0)
4545
def stop(self) -> None:
4646
# send stop command to sensor
4747
pass

external_samples/component.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,11 @@ def get_part_number(self) -> str:
5555
@abstractmethod
5656
def get_url(self) -> str:
5757
pass
58-
# This is the version of the software (returned as a (major, minor, revision) tuple where
59-
# major and minor are positive integers
60-
# revision can be an empty string or specify small changes that are less than a
61-
# minor revision
58+
# This is the version of the software (returned as a (major, minor, patch) tuple where
59+
# major, minor and patch are all positive integers
60+
# This MUST follow semantic versioning as described here: https://semver.org/
6261
@abstractmethod
63-
def get_version(self) -> tuple[int, int, str]:
62+
def get_version(self) -> tuple[int, int, int]:
6463
pass
6564

6665
# This stops all movement (if any) for the component

external_samples/rev_touch_sensor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ def get_part_number(self) -> str:
3333
return "REV-31-1425"
3434
def get_url(self) -> str:
3535
return "https://www.revrobotics.com/rev-31-1425/"
36-
def get_version(self) -> tuple[int, int, str]:
37-
return (1, 0, "")
36+
def get_version(self) -> tuple[int, int, int]:
37+
return (1, 0, 0)
3838
def stop(self) -> None:
3939
pass
4040
def reset(self) -> None:

external_samples/servo.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ def get_part_number(self) -> str:
3232
return "REV-41-1097"
3333
def get_url(self) -> str:
3434
return "https://www.revrobotics.com/rev-41-1097/"
35-
def get_version(self) -> tuple[int, int, str]:
36-
return (1, 0, "")
35+
def get_version(self) -> tuple[int, int, int]:
36+
return (1, 0, 0)
3737
def stop(self) -> None:
3838
# De-energize servo port
3939
pass

external_samples/smart_motor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ def get_part_number(self) -> str:
3131
return "REV-xx-xxxx"
3232
def get_url(self) -> str:
3333
return "https://www.revrobotics.com/rev-xx-xxxx"
34-
def get_version(self) -> tuple[int, int, str]:
35-
return (1, 0, "")
34+
def get_version(self) -> tuple[int, int, int]:
35+
return (1, 0, 0)
3636
def stop(self) -> None:
3737
# send stop command to motor
3838
pass

external_samples/sparkfun_led_stick.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ def get_part_number(self) -> str:
2323
def get_url(self) -> str:
2424
return "https://www.sparkfun.com/sparkfun-qwiic-led-stick-apa102c.html"
2525

26-
def get_version(self) -> tuple[int, int, str]:
27-
return (1, 0, "")
26+
def get_version(self) -> tuple[int, int, int]:
27+
return (1, 0, 0)
2828

2929
def stop(self) -> None:
3030
self.turn_all_off()

0 commit comments

Comments
 (0)