Skip to content

Commit 8a5bcda

Browse files
committed
Removed @AbstractMethod from start, update, and stop in component.py.
Removed empty start, update, and stop methods from component subclasses.
1 parent d972fb9 commit 8a5bcda

File tree

9 files changed

+3
-55
lines changed

9 files changed

+3
-55
lines changed

external_samples/color_range_sensor.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,16 +51,6 @@ def get_url(self) -> str:
5151
def get_version(self) -> tuple[int, int, int]:
5252
return (1, 0, 0)
5353

54-
def start(self) -> None:
55-
pass
56-
57-
def update(self) -> None:
58-
pass
59-
60-
def stop(self) -> None:
61-
# send stop command to sensor
62-
pass
63-
6454
def reset(self) -> None:
6555
pass
6656

external_samples/component.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,16 +71,13 @@ def get_url(self) -> str:
7171
def get_version(self) -> tuple[int, int, int]:
7272
pass
7373

74-
@abstractmethod
7574
def start(self) -> None:
7675
pass
7776

78-
@abstractmethod
7977
def update(self) -> None:
8078
pass
8179

8280
# This stops all movement (if any) for the component
83-
@abstractmethod
8481
def stop(self) -> None:
8582
pass
8683

external_samples/expansion_hub_motor.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@ def get_version(self) -> tuple[int, int, int]:
5555
def start(self) -> None:
5656
self.expansion_hub_motor.setEnabled(True)
5757

58-
def update(self) -> None:
59-
pass
60-
6158
def stop(self) -> None:
6259
# TODO: Send stop command to motor.
6360
pass

external_samples/expansion_hub_servo.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@ def start(self) -> None:
5555
self.expansion_hub_servo.setEnabled(True)
5656
pass
5757

58-
def update(self) -> None:
59-
pass
60-
6158
def stop(self) -> None:
6259
# TODO: Send stop command to servo.
6360
pass

external_samples/rev_touch_sensor.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,6 @@ def get_url(self) -> str:
4242
def get_version(self) -> tuple[int, int, int]:
4343
return (1, 0, 0)
4444

45-
def start(self) -> None:
46-
pass
47-
48-
def update(self) -> None:
49-
pass
50-
51-
def stop(self) -> None:
52-
pass
53-
5445
def reset(self) -> None:
5546
self.pressed_callback = None
5647
self.released_callback = None

external_samples/servo.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,8 @@ def get_url(self) -> str:
4141
def get_version(self) -> tuple[int, int, int]:
4242
return (1, 0, 0)
4343

44-
def start(self) -> None:
45-
pass
46-
47-
def update(self) -> None:
48-
pass
49-
5044
def stop(self) -> None:
51-
# De-energize servo port
45+
# TODO: De-energize servo port
5246
pass
5347

5448
def reset(self) -> None:

external_samples/smart_motor.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,8 @@ def get_url(self) -> str:
4141
def get_version(self) -> tuple[int, int, int]:
4242
return (1, 0, 0)
4343

44-
def start(self) -> None:
45-
pass
46-
47-
def update(self) -> None:
48-
pass
49-
5044
def stop(self) -> None:
51-
# send stop command to motor
45+
# TODO: send stop command to motor
5246
pass
5347

5448
def reset(self) -> None:

external_samples/spark_mini.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,8 @@ def get_url(self) -> str:
4949
def get_version(self) -> tuple[int, int, int]:
5050
return (1, 0, 0)
5151

52-
def start(self) -> None:
53-
pass
54-
55-
def update(self) -> None:
56-
pass
57-
5852
def stop(self) -> None:
59-
# send stop command to motor
53+
# TODO: send stop command to motor
6054
pass
6155

6256
def reset(self) -> None:

external_samples/sparkfun_led_stick.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,6 @@ def get_url(self) -> str:
4040
def get_version(self) -> tuple[int, int, int]:
4141
return (1, 0, 0)
4242

43-
def start(self) -> None:
44-
pass
45-
46-
def update(self) -> None:
47-
pass
48-
4943
def stop(self) -> None:
5044
self.turn_all_off()
5145

0 commit comments

Comments
 (0)