Skip to content

Commit 98101f7

Browse files
committed
Added TODO comment.
Removed unsed function.
1 parent 1f54e93 commit 98101f7

File tree

2 files changed

+7
-16
lines changed

2 files changed

+7
-16
lines changed

src/blocks/mrc_call_python_function.ts

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -78,22 +78,11 @@ export function addStaticMethodBlocks(
7878
functions: FunctionData[],
7979
contents: toolboxItems.ContentsType[]) {
8080
for (const functionData of functions) {
81-
const block = createModuleFunctionOrStaticMethodBlock(
82-
FunctionKind.STATIC, importModule, functionData.declaringClassName, functionData);
83-
contents.push(block);
84-
}
85-
}
86-
87-
function addModuleFunctionOrStaticMethodBlocks(
88-
functionKind: FunctionKind,
89-
importModule: string,
90-
moduleOrClassName: string,
91-
functions: FunctionData[],
92-
contents: toolboxItems.ContentsType[]) {
93-
for (const functionData of functions) {
94-
const block = createModuleFunctionOrStaticMethodBlock(
95-
functionKind, importModule, moduleOrClassName, functionData);
96-
contents.push(block);
81+
if (functionData.declaringClassName) {
82+
const block = createModuleFunctionOrStaticMethodBlock(
83+
FunctionKind.STATIC, importModule, functionData.declaringClassName, functionData);
84+
contents.push(block);
85+
}
9786
}
9887
}
9988

src/blocks/mrc_set_python_variable.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ import * as toolboxItems from '../toolbox/items';
3636

3737
export const BLOCK_NAME = 'mrc_set_python_variable';
3838

39+
// TODO(lizlooney): Consider combining VariableKind here with VariableKind in
40+
// mrc_get_python_variable.ts. They are identical.
3941
enum VariableKind {
4042
MODULE = 'module',
4143
CLASS = 'class',

0 commit comments

Comments
 (0)