Addressing review comments

Author: alan412

backend/API_README.md backend/README.mdbackend/API_README.md renamed to backend/README.md

@@ -23,19 +23,17 @@ A Flask-based REST API for providing storage capabilities (key-value pairs and f
 - `DELETE /storage/<path>` - Delete file or directory
 - `POST /storage/rename` - Rename file or directory
 
-## Running the Application
-
-1. Install dependencies:
-   ```bash
-   pip install flask flask-restful flask-sqlalchemy
-   ```
+## Setup
+    1. cd <your repo>/backend
+    2. python3.12 -m venv ./venv
+    3. source ./venv/bin/activate
+    4. python3.12 -m pip install -r requirements.txt
+    5. deactivate
 
-2. Run the application:
-   ```bash
-   python main.py
-   ```
-
-3. The API will be available at `http://localhost:5001`
+## Running the Application
+    1. source ./venv/bin/activate
+    2. python main.py
+    3. The API will be available at `http://localhost:5001`
 
 ## Example Usage
 

backend/main.py

@@ -26,7 +26,7 @@ def handle_preflight():
 
 # Configure SQLite database
 basedir = os.path.abspath(os.path.dirname(__file__))
-app.config['SQLALCHEMY_DATABASE_URI'] = f'sqlite:///{os.path.join(basedir, "storage.db")}'
+app.config['SQLALCHEMY_DATABASE_URI'] = f'sqlite:///{os.path.join(basedir, "projects.db")}'
 app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False
 
 db = SQLAlchemy(app)

backend/requirements.txt

@@ -0,0 +1,14 @@
+aniso8601==10.0.1
+blinker==1.9.0
+click==8.2.1
+Flask==3.1.1
+Flask-RESTful==0.3.10
+Flask-SQLAlchemy==3.1.1
+itsdangerous==2.2.0
+Jinja2==3.1.6
+MarkupSafe==3.0.2
+pytz==2025.2
+six==1.17.0
+SQLAlchemy==2.0.42
+typing_extensions==4.14.1
+Werkzeug==3.1.3

backend/storage.db

@@ -24,7 +24,7 @@ import * as commonStorage from './common_storage';
 
 const API_BASE_URL = 'http://localhost:5001';
 
-async function isServerAvailable(): Promise<boolean> {
+export async function isServerAvailable(): Promise<boolean> {
   try {
     // Create a timeout promise
     const timeoutPromise = new Promise<never>((_, reject) => {
@@ -33,7 +33,7 @@ async function isServerAvailable(): Promise<boolean> {
 
     // Race between the fetch and timeout
     const response = await Promise.race([
-      fetch(`${API_BASE_URL}/`, { method: 'GET' }),
+      fetch(`${API_BASE_URL}/`),
       timeoutPromise
     ]);
 
@@ -44,7 +44,7 @@ async function isServerAvailable(): Promise<boolean> {
   }
 }
 
-class ServerSideStorage implements commonStorage.Storage {
+export class ServerSideStorage implements commonStorage.Storage {
 
   async saveEntry(entryKey: string, entryValue: string): Promise<void> {
     const response = await fetch(`${API_BASE_URL}/entries/${encodeURIComponent(entryKey)}`, {
@@ -86,27 +86,6 @@ class ServerSideStorage implements commonStorage.Storage {
   }
 
   async rename(oldPath: string, newPath: string): Promise<void> {
-    if (oldPath.endsWith('/')) {
-      return this.renameDirectory(oldPath, newPath);
-    }
-    return this.renameFile(oldPath, newPath);
-  }
-
-  private async renameDirectory(oldPath: string, newPath: string): Promise<void> {
-    const response = await fetch(`${API_BASE_URL}/storage/rename`, {
-      method: 'POST',
-      headers: {
-        'Content-Type': 'application/json',
-      },
-      body: JSON.stringify({ old_path: oldPath, new_path: newPath }),
-    });
-    
-    if (!response.ok) {
-      throw new Error(`Failed to rename directory: ${response.statusText}`);
-    }
-  }
-
-  private async renameFile(oldPath: string, newPath: string): Promise<void> {
     const response = await fetch(`${API_BASE_URL}/storage/rename`, {
       method: 'POST',
       headers: {
@@ -116,7 +95,7 @@ class ServerSideStorage implements commonStorage.Storage {
     });
 
     if (!response.ok) {
-      throw new Error(`Failed to rename file: ${response.statusText}`);
+      throw new Error(`Failed to rename: ${response.statusText}`);
     }
   }
 
@@ -149,34 +128,12 @@ class ServerSideStorage implements commonStorage.Storage {
   }
 
   async delete(path: string): Promise<void> {
-    if (path.endsWith('/')) {
-      return this.deleteDirectory(path);
-    }
-    return this.deleteFile(path);
-  }
-
-  private async deleteDirectory(path: string): Promise<void> {
     const response = await fetch(`${API_BASE_URL}/storage/${encodeURIComponent(path)}`, {
       method: 'DELETE',
     });
 
     if (!response.ok) {
-      throw new Error(`Failed to delete directory: ${response.statusText}`);
+      throw new Error(`Failed to delete: ${response.statusText}`);
     }
   }
-
-  private async deleteFile(filePath: string): Promise<void> {
-    const response = await fetch(`${API_BASE_URL}/storage/${encodeURIComponent(filePath)}`, {
-      method: 'DELETE',
-    });
-    
-    if (!response.ok) {
-      if (response.status === 404) {
-        throw new Error(`File not found: ${filePath}`);
-      }
-      throw new Error(`Failed to delete file: ${response.statusText}`);
-    }
-  }
-}
-
-export { ServerSideStorage, isServerAvailable };
+}