Removed listFilePaths from storage interface.

Removed unused constants and functions in names.ts.

Author: lizlooney

src/storage/client_side_storage.ts

@@ -209,38 +209,6 @@ class ClientSideStorage implements commonStorage.Storage {
     });
   }
 
-  // TODO(lizlooney): remove listFilePaths
-  async listFilePaths(opt_filePathRegexPattern?: string): Promise<string[]> {
-
-    const regExp = opt_filePathRegexPattern
-        ? new RegExp(opt_filePathRegexPattern)
-        : null;
-    return new Promise((resolve, reject) => {
-      const filePaths: string[] = [];
-      const openKeyCursorRequest = this.db.transaction([FILES_STORE_NAME], 'readonly')
-          .objectStore(FILES_STORE_NAME)
-          .openKeyCursor();
-      openKeyCursorRequest.onerror = () => {
-        console.log('IndexedDB openKeyCursor request failed. openKeyCursorRequest.error is...');
-        console.log(openKeyCursorRequest.error);
-        reject(new Error('IndexedDB openKeyCursor request failed.'));
-      };
-      openKeyCursorRequest.onsuccess = () => {
-        const cursor = openKeyCursorRequest.result;
-        if (cursor && cursor.key) {
-          const filePath: string = cursor.key as string;
-          if (!regExp || regExp.test(filePath)) {
-            filePaths.push(filePath);
-          }
-          cursor.continue();
-        } else {
-          // The cursor is done. We have finished reading all the files.
-          resolve(filePaths);
-        }
-      };
-    });
-  }
-
   async rename(oldPath: string, newPath: string): Promise<void> {
     if (oldPath.endsWith('/')) {
       return this.renameDirectory(oldPath, newPath);

src/storage/common_storage.ts

@@ -30,9 +30,6 @@ export interface Storage {
 
   list(path: string): Promise<string[]>;
 
-  // TODO(lizlooney): remove listFilePaths
-  listFilePaths(opt_filePathRegexPattern?: string): Promise<string[]>;
-
   rename(oldPath: string, newPath: string): Promise<void>;
 
   fetchFileContentText(filePath: string): Promise<string>;

src/storage/names.ts

@@ -56,17 +56,14 @@ export const CLASS_NAME_ROBOT = 'Robot';
 export const CLASS_NAME_TELEOP = 'Teleop';
 
 // The extension of all JSON files is .json.
-export const JSON_FILE_EXTENSION = '.json';
+const JSON_FILE_EXTENSION = '.json';
 
 // The extension of a downloaded project is .blocks.
 export const UPLOAD_DOWNLOAD_FILE_EXTENSION = '.blocks';
 
 // The file name of the project info file.
 const PROJECT_INFO_FILE_NAME = 'project.info.json';
 
-// The file name of the project info file.
-const ROBOT_MODULE_FILE_NAME = 'Robot.robot.json';
-
 // A project name starts with an uppercase letter, followed by alphanumeric characters.
 const REGEX_PROJECT_NAME_PART = '[A-Z][A-Za-z0-9]*';
 
@@ -81,9 +78,9 @@ const REGEX_MODULE_TYPE_PART = '\.(robot|mechanism|opmode)';
 
 export const PROJECTS_DIRECTORY_PATH = '/projects/';
 
-// This regex is used to extract the project name and file name from a file path.
+// This regex is used to extract the project name from a file path.
 const REGEX_FILE_PATH = '^' + escapeRegExp(PROJECTS_DIRECTORY_PATH) +
-    '(' + REGEX_PROJECT_NAME_PART + ')/(.*' + escapeRegExp(JSON_FILE_EXTENSION) + ')$';
+    '(' + REGEX_PROJECT_NAME_PART + ')/.*' + escapeRegExp(JSON_FILE_EXTENSION) + '$';
 
 // This regex is used to extract the class name from a module path.
 const REGEX_MODULE_PATH = '^' + escapeRegExp(PROJECTS_DIRECTORY_PATH) +
@@ -192,18 +189,6 @@ export function getProjectName(filePath: string): string {
   return result[1];
 }
 
-/**
- * Returns the file name for given file path.
- */
-export function getFileName(filePath: string): string {
-  const regex = new RegExp(REGEX_FILE_PATH);
-  const result = regex.exec(filePath)
-  if (!result) {
-    throw new Error('Unable to extract the file name from "' + filePath + '"');
-  }
-  return result[2];
-}
-
 /**
  * Returns true if the given file name is a valid module file name.
  */