Split up App into multiple react components #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found out that vite doesn't use App.css
lizlooney
approved these changes
Mar 23, 2025
src/reactComponents/CodeDisplay.tsx
Outdated
| */ | ||
|
|
||
| /** | ||
| * @author [email protected] (Liz Looney) |
Collaborator
There was a problem hiding this comment.
I didn't write this stuff either. Brandon wrote it (or got it from somewhere).
Collaborator
Author
There was a problem hiding this comment.
@bhjelstrom - were you the author of this file? If so, who should I put the copyright as?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize for how massive this pull request is.
The main thing it accomplishes is pulling out the outline and all file operations into a separate react component that knows nothing about blockly.
There is still work I want to do to simplify and clean the react up but those should be done in smaller pull requests where there is a chance of reviewing it, testing it, and checking for correctness.
Fixes #65