Improved field validators #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and isMethodNameUsed to make function makeLegalName in validator.ts. Updated mrc_class_method_def, mrc_component, mrc_event, and mrc_mechanism blocks to use makeLegalName.
…nd events are dragged into the holder. Use makeLegalName to validate parameter names.
alan412
reviewed
Nov 25, 2025
Collaborator
alan412
left a comment
alan412
left a comment
There was a problem hiding this comment.
I really like the moving this to validator.ts and out of everywhere else. I haven't checked this on my system yet to make sure it fixes all the issues. I'll try to do that tonight. I had only one very minor comment.
alan412
approved these changes
Nov 25, 2025
Collaborator
alan412
left a comment
alan412
left a comment
There was a problem hiding this comment.
Checked it when I got home. works great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved field validators in mrc_class_method_def, mrc_component, mrc_event, and mrc_mechanism blocks.
Fixes #332
Fixes #333
Fixes #324
Fixes #233
Fixes #276