Skip to content

Commit 712c402

Browse files
committed
Skip unsupported group check on post-quantum exchange agreements
1 parent 42b7203 commit 712c402

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

contrib/cHttpRequest.cls

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1742,7 +1742,7 @@ Private Function pvToStringAndFree(ByVal lPtr As Long) As Variant
17421742
End If
17431743
End Function
17441744

1745-
Public Function SetCookie(ByVal sDomain As String, ByVal sPath As String, ByVal sValue As String)
1745+
Public Sub SetCookie(ByVal sDomain As String, ByVal sPath As String, ByVal sValue As String)
17461746
Dim oCol As Collection
17471747

17481748
If Left$(sDomain, 1) = "." Then
@@ -1767,7 +1767,7 @@ Public Function SetCookie(ByVal sDomain As String, ByVal sPath As String, ByVal
17671767
Set m_oCookies.Item(sDomain) = oCol
17681768
End If
17691769
oCol.Add sPath & Chr$(1) & sValue
1770-
End Function
1770+
End Sub
17711771

17721772
Private Function pvGetAllCookies(ByVal sDomain As String, ByVal sPath As String) As String
17731773
Dim vRetVal As Variant

src/mdTlsThunks.bas

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3018,26 +3018,25 @@ Private Function pvTlsParseHandshakeClientHello(uCtx As UcsTlsContext, uInput As
30183018
If .HelloRetryRequest And lExchGroup <> .HelloRetryExchGroup Then
30193019
lExchGroup = 0
30203020
End If
3021+
eExchAlgo = 0
30213022
Select Case lExchGroup
30223023
Case TLS_GROUP_X25519
30233024
eExchAlgo = ucsTlsAlgoExchX25519
30243025
Case TLS_GROUP_SECP256R1
30253026
eExchAlgo = ucsTlsAlgoExchSecp256r1
30263027
Case TLS_GROUP_SECP384R1
30273028
eExchAlgo = ucsTlsAlgoExchSecp384r1
3028-
Case TLS_GROUP_X448, TLS_GROUP_SECP521R1
3029-
eExchAlgo = 0
3029+
Case TLS_GROUP_SECP521R1, TLS_GROUP_X448
3030+
'--- unsupported ecc curves
30303031
Case TLS_GROUP_FFDHE_FIRST To TLS_GROUP_FFDHE_LAST
3031-
eExchAlgo = 0
3032-
Case TLS_GROUP_FFDHE_PRIVATE_USE_FIRST To TLS_GROUP_FFDHE_PRIVATE_USE_LAST
3033-
eExchAlgo = 0
3034-
Case TLS_GROUP_ECDHE_PRIVATE_USE_FIRST To TLS_GROUP_ECDHE_PRIVATE_USE_LAST
3035-
eExchAlgo = 0
3032+
'--- ffdhe
3033+
Case TLS_GROUP_FFDHE_PRIVATE_USE_FIRST To TLS_GROUP_FFDHE_PRIVATE_USE_LAST, TLS_GROUP_ECDHE_PRIVATE_USE_FIRST To TLS_GROUP_ECDHE_PRIVATE_USE_LAST
3034+
'--- private use
30363035
Case Else
30373036
If (lExchGroup And &HFF) = lExchGroup \ &H100 And (lExchGroup And &HF) = &HA Then
3038-
eExchAlgo = 0 '--- grease from RFC8701
3037+
'--- grease from RFC8701
30393038
Else
3040-
GoTo UnsupportedExchGroup
3039+
'GoTo UnsupportedExchGroup
30413040
End If
30423041
End Select
30433042
Select Case True
@@ -3106,7 +3105,7 @@ Private Function pvTlsParseHandshakeClientHello(uCtx As UcsTlsContext, uInput As
31063105
If (lExchGroup And &HFF) = lExchGroup \ &H100 And (lExchGroup And &HF) = &HA Then
31073106
'--- grease from RFC8701
31083107
Else
3109-
GoTo UnsupportedExchGroup
3108+
'GoTo UnsupportedExchGroup
31103109
End If
31113110
End Select
31123111
End If

0 commit comments

Comments
 (0)