refactoring, renaming, first steps for guided setup

Author: wrecks-code

config.ini

@@ -1,6 +1,6 @@
-[SETTINGS]
+[Settings]
 monitor_name = DELL U2422H
-multimonitorpath = C:\\App_Install\\multimonitortool-x64\\MultiMonitorTool.exe
-autostart = False
-first_start = False
+multimonitortool_executable = C:\\App_Install\\multimonitortool-x64\\MultiMonitorTool.exe
+start_with_windows = no
+first_start = no
 

SimpleMonitorControlTray.py renamed to main.py

@@ -1,10 +1,6 @@
-import smct_pkg.config as config
-import smct_pkg.tray as tray
-
+from smct_pkg import config, tray
 
 # TODO add selection of monitor at startup
-# TODO clean up imports like so:
-# import smct_pkg.config
 
 
 def main():

smct_pkg/config.py

@@ -1,16 +1,25 @@
 import configparser
 import os
 
-import smct_pkg.mmt as mmt
-import smct_pkg.notification as notification
-import smct_pkg.paths as paths
+from smct_pkg import multimonitortool, notification, paths, registry, ui_strings
 
-MMT_PATH, MONITOR_NAME, AUTOSTART, FIRST_START = (
-    "",
-    "",
-    False,
-    True,
-)
+ENCODING = "utf-8"
+
+# keys
+SETTINGS_SECTION = "Settings"
+MONITOR_NAME_KEY = "monitor_name"
+MULTIMONITORTOOL_EXECUTABLE_KEY = "multimonitortool_executable"
+START_WITH_WINDOWS_KEY = "start_with_windows"
+FIRT_START_KEY = "first_start"
+
+# values
+MMT_PATH_VALUE = ""
+MONITOR_NAME_VALUE = ""
+AUTOSTART_VALUE = False
+FIRST_START_VALUE = True
+
+_configparser = configparser.ConfigParser()
+_configparser.read(paths.CONFIG_PATH, encoding=ENCODING)
 
 
 def check_for_missing_files():
@@ -19,60 +28,69 @@ def check_for_missing_files():
         os.makedirs(paths.ASSETS_DIR_PATH)
     # Check for Icons
     if not os.path.exists(paths.ASSETS_ICON_ENABLED_PATH):
-        notification.send_error(paths.ASSETS_ICON_ENABLED_PATH + paths.FILE_NOT_FOUND)
+        notification.send_error(
+            paths.ASSETS_ICON_ENABLED_PATH + ui_strings.FILE_NOT_FOUND
+        )
     if not os.path.exists(paths.ASSETS_ICON_DISABLED_PATH):
-        notification.send_error(paths.ASSETS_ICON_DISABLED_PATH + paths.FILE_NOT_FOUND)
+        notification.send_error(
+            paths.ASSETS_ICON_DISABLED_PATH + ui_strings.FILE_NOT_FOUND
+        )
 
     # Check for MultiMonitorTool
-    if not os.path.exists(MMT_PATH):
-        notification.send_error(MMT_PATH + paths.FILE_NOT_FOUND)
+    if not os.path.exists(MMT_PATH_VALUE):
+        notification.send_error(MMT_PATH_VALUE + ui_strings.FILE_NOT_FOUND)
 
     # Check for temp folder
     if not os.path.exists(paths.TEMP_DIR_PATH):
         os.makedirs(paths.TEMP_DIR_PATH)
 
     # Check for MultiMonitorTool CSV
     if not os.path.exists(paths.MMT_CSV_PATH):
-        mmt.save_mmt_config()
+        multimonitortool.save_mmt_config()
 
 
 def read_config():
     # Check if config.ini file is present
     if not os.path.exists(paths.CONFIG_PATH):
-        notification.send_error(paths.CONFIG_PATH + paths.FILE_NOT_FOUND)
+        notification.send_error(paths.CONFIG_PATH + ui_strings.FILE_NOT_FOUND)
 
-    global AUTOSTART, MMT_PATH, MONITOR_NAME, FIRST_START
+    # * pylint: disable=global-statement
+    global AUTOSTART_VALUE, MMT_PATH_VALUE, MONITOR_NAME_VALUE, FIRST_START_VALUE
 
-    config = configparser.ConfigParser()
+    MMT_PATH_VALUE = _configparser.get(
+        SETTINGS_SECTION, MULTIMONITORTOOL_EXECUTABLE_KEY
+    )
+    MONITOR_NAME_VALUE = _configparser.get(SETTINGS_SECTION, MONITOR_NAME_KEY)
+    AUTOSTART_VALUE = _configparser.getboolean(SETTINGS_SECTION, START_WITH_WINDOWS_KEY)
+    FIRST_START_VALUE = _configparser.getboolean(SETTINGS_SECTION, FIRT_START_KEY)
 
-    config.read(paths.CONFIG_PATH, encoding="utf-8")
+    if AUTOSTART_VALUE:
+        registry.add_to_autostart()
+    else:
+        registry.remove_from_autostart()
 
-    MMT_PATH = config.get("SETTINGS", "multimonitorpath")
-    MONITOR_NAME = config.get("SETTINGS", "monitor_name")
-    AUTOSTART = config.get("SETTINGS", "autostart")
-    FIRST_START = config.get("SETTINGS", "first_start")
-
-    check_for_missing_files()
-
-    if FIRST_START == "True":
+    if FIRST_START_VALUE:
+        # TODO: Do something else here
         notification.send_notification(
-            "If you do not have all Monitors enabled and configured as you like right now, please do so and then right click the tray icon to save the monitor layout.",
+            "placeholder",
             30,
         )
-        FIRST_START = "False"
-        set_config_value("SETTINGS", "first_start", FIRST_START)
+        FIRST_START_VALUE = False
+        set_config_value(SETTINGS_SECTION, FIRT_START_KEY, FIRST_START_VALUE)
+
+    check_for_missing_files()
 
 
-def set_config_value(category, key, value):
-    config = configparser.ConfigParser()
-    config.read(paths.CONFIG_PATH, encoding="utf-8")
-    config[category][key] = value
-    with open(paths.CONFIG_PATH, "w") as configfile:
-        config.write(configfile)
+def set_config_value(section, key, value):
+    if isinstance(value, bool):
+        value_str = "yes" if value else "no"
+    else:
+        value_str = str(value)
+    _configparser[section][key] = value_str
+    with open(paths.CONFIG_PATH, "w", encoding=ENCODING) as configfile:
+        _configparser.write(configfile)
     # print("Setting config value: " + key + " to " + value)
 
 
-def get_config_value(category, key):
-    config = configparser.ConfigParser()
-    config.read(paths.CONFIG_PATH, encoding="utf-8")
-    return config.get(category, key)
+def get_config_value(section, key):
+    return _configparser.get(section, key)

smct_pkg/customtkinter_example.py

@@ -0,0 +1,91 @@
+import customtkinter
+import tkinterDnD
+
+customtkinter.set_ctk_parent_class(tkinterDnD.Tk)
+
+customtkinter.set_appearance_mode("dark")  # Modes: "System" (standard), "Dark", "Light"
+customtkinter.set_default_color_theme(
+    "dark-blue"
+)  # Themes: "blue" (standard), "green", "dark-blue"
+
+app = customtkinter.CTk()
+app.geometry("400x780")
+app.title("CustomTkinter simple_example.py")
+
+print(type(app), isinstance(app, tkinterDnD.Tk))
+
+
+def button_callback():
+    print("Button click", combobox_1.get())
+
+
+def slider_callback(value):
+    progressbar_1.set(value)
+
+
+frame_1 = customtkinter.CTkFrame(master=app)
+frame_1.pack(pady=20, padx=60, fill="both", expand=True)
+
+label_1 = customtkinter.CTkLabel(master=frame_1, justify=customtkinter.LEFT)
+label_1.pack(pady=10, padx=10)
+
+progressbar_1 = customtkinter.CTkProgressBar(master=frame_1)
+progressbar_1.pack(pady=10, padx=10)
+
+button_1 = customtkinter.CTkButton(master=frame_1, command=button_callback)
+button_1.pack(pady=10, padx=10)
+
+slider_1 = customtkinter.CTkSlider(
+    master=frame_1, command=slider_callback, from_=0, to=1
+)
+slider_1.pack(pady=10, padx=10)
+slider_1.set(0.5)
+
+entry_1 = customtkinter.CTkEntry(master=frame_1, placeholder_text="CTkEntry")
+entry_1.pack(pady=10, padx=10)
+
+optionmenu_1 = customtkinter.CTkOptionMenu(
+    frame_1, values=["Option 1", "Option 2", "Option 42 long long long..."]
+)
+optionmenu_1.pack(pady=10, padx=10)
+optionmenu_1.set("CTkOptionMenu")
+
+combobox_1 = customtkinter.CTkComboBox(
+    frame_1, values=["Option 1", "Option 2", "Option 42 long long long..."]
+)
+combobox_1.pack(pady=10, padx=10)
+combobox_1.set("CTkComboBox")
+
+checkbox_1 = customtkinter.CTkCheckBox(master=frame_1)
+checkbox_1.pack(pady=10, padx=10)
+
+radiobutton_var = customtkinter.IntVar(value=1)
+
+radiobutton_1 = customtkinter.CTkRadioButton(
+    master=frame_1, variable=radiobutton_var, value=1
+)
+radiobutton_1.pack(pady=10, padx=10)
+
+radiobutton_2 = customtkinter.CTkRadioButton(
+    master=frame_1, variable=radiobutton_var, value=2
+)
+radiobutton_2.pack(pady=10, padx=10)
+
+switch_1 = customtkinter.CTkSwitch(master=frame_1)
+switch_1.pack(pady=10, padx=10)
+
+text_1 = customtkinter.CTkTextbox(master=frame_1, width=200, height=70)
+text_1.pack(pady=10, padx=10)
+text_1.insert("0.0", "CTkTextbox\n\n\n\n")
+
+segmented_button_1 = customtkinter.CTkSegmentedButton(
+    master=frame_1, values=["CTkSegmentedButton", "Value 2"]
+)
+segmented_button_1.pack(pady=10, padx=10)
+
+tabview_1 = customtkinter.CTkTabview(master=frame_1, width=300)
+tabview_1.pack(pady=10, padx=10)
+tabview_1.add("CTkTabview")
+tabview_1.add("Tab 2")
+
+app.mainloop()

smct_pkg/customtkintertest.py

@@ -0,0 +1,50 @@
+import customtkinter
+import tkinterDnD
+
+from smct_pkg import gui
+
+# https://github.com/TomSchimansky/CustomTkinter/tree/master/examples
+# https://github.com/TomSchimansky/CustomTkinter
+
+customtkinter.set_ctk_parent_class(tkinterDnD.Tk)
+
+customtkinter.set_appearance_mode("dark")  # Modes: "System" (standard), "Dark", "Light"
+customtkinter.set_default_color_theme(
+    "dark-blue"
+)  # Themes: "blue" (standard), "green", "dark-blue"
+
+app = customtkinter.CTk()
+app.geometry("300x180")
+app.title("CustomTkinter simple_example.py")
+
+
+def button_callback():
+    gui.select_multimonitortool()
+
+
+frame = customtkinter.CTkFrame(master=app)
+frame.pack(pady=20, padx=20, fill="both", expand=True)
+
+select_multimonitortool_label = customtkinter.CTkLabel(
+    text="Please select your MultiMonitorTool.exe",
+    master=frame,
+    justify=customtkinter.LEFT,
+)
+select_multimonitortool_label.pack(pady=10, padx=10)
+
+browse_button = customtkinter.CTkButton(
+    text="Browse...", master=frame, command=button_callback
+)
+browse_button.pack(pady=10, padx=10)
+
+
+app.mainloop()
+
+# pylint: disable=pointless-string-statement
+"""
+monitor_selection_menu = customtkinter.CTkOptionMenu(
+    frame, values=["Option 1", "Option 2", "Option 42 long long long..."]
+)
+monitor_selection_menu.pack(pady=10, padx=10)
+monitor_selection_menu.set("Select your monitor")
+"""