whenever new document uploaded - clear annexes - add more specs

Author: tsubik

app/resources/concerns/operator_documentable.rb

@@ -52,6 +52,7 @@ def attachment
 
     def attachment=(attachment)
       @model.build_document_file(attachment: attachment)
+      @model.annex_documents = [] # clear annexes when new document is uploaded
       # TODO: check if there is better workaround for this issue https://github.com/rails/rails/issues/49898
       # flipping activerecord flag about commit on first saved instance does not work
       # when using build_document_file probably because of autosaving - save is called twice and in after commit we lose saved_changes hash somehow

spec/integration/v1/operator_documents_spec.rb

@@ -141,5 +141,78 @@ def sign_publication_authorization!
         end
       end
     end
+
+    describe "Uploading new document" do
+      let(:operator_document) { create(:operator_document_fmu, operator: operator_user.operator) }
+
+      describe "For operator user" do
+        it "Returns error object when validation fails" do
+          patch(
+            "/operator-document-fmus/#{operator_document.id}",
+            params: jsonapi_params("operator-document-fmus", operator_document.id, {"start-date": nil, "expire-date": nil}),
+            headers: operator_user_headers
+          )
+          expect(parsed_body).to eq(jsonapi_errors(422, 100, {"start-date": ["can't be blank"], "expire-date": ["can't be blank"]}))
+          expect(status).to eq(422)
+        end
+
+        it "Returns success object when document is uploaded" do
+          create(:operator_document_annex, operator_document: operator_document)
+          patch(
+            "/operator-document-fmus/#{operator_document.id}",
+            params: jsonapi_params(
+              "operator-document-fmus",
+              operator_document.id,
+              {
+                attachment: base64_file_data(Rails.root.join("spec", "support", "files", "doc.pdf")),
+                "start-date": "2025-12-01",
+                "expire-date": "2040-12-01"
+              }
+            ),
+            headers: operator_user_headers
+          )
+
+          expect(parsed_data[:id]).not_to be_empty
+          expect(parsed_attributes[:status]).to eq("doc_pending")
+          expect(parsed_attributes[:"start-date"]).to eq("2025-12-01")
+          expect(parsed_attributes[:"expire-date"]).to eq("2040-12-01")
+          expect(parsed_attributes[:"source-type"]).to eq("company")
+          expect(parsed_attributes[:"uploaded-by"]).to eq("operator")
+          expect(status).to eq(200)
+
+          # annexes should be cleared as new document uploaded
+          operator_document = OperatorDocument.find(parsed_data[:id])
+          expect(operator_document.annex_documents.count).to eq(0)
+        end
+
+        context "when trying to upload for another operator" do
+          let(:other_operator_document) { create(:operator_document_fmu) }
+
+          it "Does not allow to upload document for another operator" do
+            patch(
+              "/operator-document-fmus/#{other_operator_document.id}",
+              params: jsonapi_params("operator-document-fmus", other_operator_document.id, {}),
+              headers: operator_user_headers
+            )
+
+            expect(parsed_body).to eq(default_status_errors(401))
+            expect(status).to eq(401)
+          end
+        end
+      end
+
+      describe "For not operator user" do
+        it "Does not allow to upload document by not operator users" do
+          patch(
+            "/operator-document-fmus/#{operator_document.id}",
+            params: jsonapi_params("operator-document-fmus", operator_document.id, {}),
+            headers: user_headers
+          )
+
+          expect(parsed_body).to eq(default_status_errors(401))
+          expect(status).to eq(401)
+        end
+      end
+    end
   end
 end

spec/support/integration_helper.rb

@@ -180,4 +180,8 @@ def jsonapi_params(type, id = nil, attributes = nil)
   def try_to_call(callable_or_not)
     callable_or_not.respond_to?(:call) ? instance_exec(&callable_or_not) : callable_or_not
   end
+
+  def base64_file_data(filepath)
+    "data:application/pdf;base64,#{Base64.encode64(File.read(filepath))}"
+  end
 end