Skip to content

Commit 8fd660a

Browse files
committed
fix specs
1 parent 70bc34f commit 8fd660a

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

spec/controllers/admin/quality_controls_controller_spec.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
reviewable_id: observation.id,
2424
reviewable_type: "Observation",
2525
reviewer_id: admin.id,
26+
decision: "Rejected",
2627
passed: false,
2728
comment: "Comment"
2829
}

spec/factories/quality_controls.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,13 @@
1414
#
1515
FactoryBot.define do
1616
factory :quality_control do
17-
reviewable { create(:observation, validation_status: "QC2 in progress") }
17+
reviewable { build(:observation, validation_status: "QC2 in progress") }
1818
reviewer { build(:admin) }
1919
passed { true }
20+
decision { "Ready for publication" }
2021

2122
trait :not_passed do
23+
decision { "Rejected" }
2224
passed { false }
2325
comment { "Quality control not passed" }
2426
end

0 commit comments

Comments
 (0)