observation report: add validate for mission_type

Author: tsubik

app/models/observation_report.rb

@@ -20,7 +20,7 @@ class ObservationReport < ApplicationRecord
 
   acts_as_paranoid
 
-  enum :mission_type, {mandated: 0, semi_mandated: 1, external: 2}, prefix: true, scopes: false
+  enum :mission_type, {mandated: 0, semi_mandated: 1, external: 2}, prefix: true, scopes: false, validate: true
   ransacker :mission_type, formatter: proc { |v| mission_types[v] }
 
   normalizes :title, with: -> { it.strip }

spec/models/observation_report_spec.rb

@@ -32,6 +32,12 @@
       expect(subject.errors.messages[:attachment]).to include("can't be blank")
     end
 
+    it "validates mission_type inclusion" do
+      subject.mission_type = nil
+      expect(subject).not_to be_valid
+      expect(subject.errors.messages[:mission_type]).to include("is not included in the list")
+    end
+
     it "accepts only pdf files" do
       subject.attachment = Rack::Test::UploadedFile.new(File.join(Rails.root, "spec", "support", "files", "image.png"))
       expect(subject).not_to be_valid