change user locale to be not null and have default value

Author: tsubik

app/models/user.rb

@@ -69,7 +69,7 @@ class User < ApplicationRecord
 
   validates :email, uniqueness: true
   validates :name, presence: true
-  validates :locale, inclusion: {in: I18n.available_locales.map(&:to_s), allow_blank: true}
+  validates :locale, presence: true, inclusion: {in: I18n.available_locales.map(&:to_s)}
   # password length and confirmation match is handled by Devise
   validates :password_confirmation, presence: true, if: -> { password.present? }
   validates :password, format: {with: /\A(?=.*[a-z])(?=.*[A-Z])(?=.*\d).+\z/, message: :password_complexity}, if: -> { password.present? }

db/migrate/20250716100255_change_user_locale_to_not_null.rb

@@ -0,0 +1,14 @@
+class ChangeUserLocaleToNotNull < ActiveRecord::Migration[7.2]
+  class User < ApplicationRecord
+  end
+
+  def up
+    User.where(locale: ["", nil]).update(locale: "en")
+
+    change_column :users, :locale, :string, null: false, default: "en"
+  end
+
+  def down
+    change_column :users, :locale, :string, null: true, default: nil
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.2].define(version: 2025_05_21_075002) do
+ActiveRecord::Schema[7.2].define(version: 2025_07_16_100255) do
   create_schema "tiger"
   create_schema "tiger_data"
   create_schema "topology"
@@ -1127,7 +1127,7 @@
     t.integer "observer_id"
     t.integer "operator_id"
     t.integer "holding_id"
-    t.string "locale"
+    t.string "locale", default: "en", null: false
     t.string "first_name"
     t.string "last_name"
     t.boolean "organization_account", default: false, null: false

spec/models/user_spec.rb

@@ -58,6 +58,12 @@
 
     it { is_expected.to validate_length_of(:password).is_at_least(10).is_at_most(128) }
 
+    it "is invalid without locale" do
+      subject.locale = nil
+      expect(subject.valid?).to eq(false)
+      expect(subject.errors[:locale]).to include("can't be blank")
+    end
+
     it "is invalid when password does not contain lowercase letter" do
       subject.password = "PASSWORD1234"
       subject.password_confirmation = "PASSWORD1234"