fix: send dataframe events in run mode

* fix: send dataframe events in run mode

* fix: make cursor consistent betwwen modes for tag block

Author: UladzislauK-Writer

src/ui/src/components/core/content/CoreDataframe.vue

@@ -346,15 +346,12 @@ const relativePosition = ref(0);
 const columnWidths = ref<number[]>([]);
 let columnBeingWidthAdjusted: number = null;
 
-const wf = inject(injectionKeys.core);
-const instancePath = inject(injectionKeys.instancePath);
-
 const {
 	handleUpdateCell,
 	handleAddRow,
 	handleActionRow,
 	isBusy: isUpdatingBusy,
-} = useDataFrameValueBroker(wf, instancePath, rootEl, table);
+} = useDataFrameValueBroker(rootEl, table);
 
 async function onAddRow() {
 	await handleAddRow();

src/ui/src/components/core/content/CoreDataframe/useDataframeValueBroker.ts

@@ -1,21 +1,15 @@
-import { ComponentPublicInstance, computed, Ref, ShallowRef } from "vue";
+import { ComponentPublicInstance, Ref, ShallowRef } from "vue";
 import { type internal } from "arquero";
 import { ARQUERO_INTERNAL_ID, UNNAMED_INDEX_COLUMN_PATTERN } from "./constants";
 import { useJobs } from "./useJobs";
-import { Core, InstancePath } from "@/writerTypes";
-import { useComponentLinkedBlueprints } from "@/composables/useComponentBlueprints";
 
 /**
  * Encapsulates the logic to update an Arquero table and sync it with the backend
  */
 export function useDataFrameValueBroker(
-	wf: Core,
-	instancePath: InstancePath,
 	emitterEl: Ref<HTMLElement | ComponentPublicInstance>,
 	table: ShallowRef<internal.ColumnTable | null>,
 ) {
-	const componentId = instancePath.at(-1).componentId;
-	const component = computed(() => wf.getComponentById(componentId));
 
 	type Job =
 		| {
@@ -69,8 +63,6 @@ export function useDataFrameValueBroker(
 			[ARQUERO_INTERNAL_ID]: () => aq.op.row_number(),
 		});
 
-		if (!isEventUsed(eventType)) return;
-
 		return new Promise((res) => {
 			const event = new CustomEvent(eventType, {
 				detail: {
@@ -88,7 +80,6 @@ export function useDataFrameValueBroker(
 	async function handlerActionRow(action: string, rowIndex: number) {
 		const eventType = "wf-dataframe-action";
 		if (!table.value) throw Error("Table is not ready");
-		if (!isEventUsed(eventType)) return;
 
 		const rowIndexBackend = rowIndex - 1; // 0-based index (arquero is based on 1-based index)
 
@@ -137,8 +128,6 @@ export function useDataFrameValueBroker(
 
 		table.value = table.value.derive({ [columnName]: updater });
 
-		if (!isEventUsed(eventType)) return;
-
 		const record = cleanRecord(table.value.filter(recordFilter).object());
 
 		return new Promise((res) => {
@@ -153,18 +142,6 @@ export function useDataFrameValueBroker(
 		});
 	}
 
-	function isEventUsed(eventType: string): boolean {
-		const isHandlerSet = component.value.handlers?.[eventType];
-		const isBindingSet = component.value.binding?.eventType == eventType;
-		const isBlueprintAttached = useComponentLinkedBlueprints(
-			wf,
-			componentId,
-			eventType,
-		).isLinked.value;
-
-		return Boolean(isHandlerSet || isBindingSet || isBlueprintAttached);
-	}
-
 	function dispatchEvent(event: CustomEvent) {
 		if (emitterEl.value instanceof HTMLElement) {
 			emitterEl.value.dispatchEvent(event);

src/ui/src/components/core/content/CoreTags.vue

@@ -35,7 +35,6 @@ import {
 	primaryTextColor,
 } from "@/renderer/sharedStyleFields";
 import { WdsColor } from "@/wds/tokens";
-import { useComponentLinkedBlueprints } from "@/composables/useComponentBlueprints";
 
 const clickHandlerStub = `
 def handle_tag_click(state, payload):
@@ -90,7 +89,7 @@ export default {
 };
 </script>
 <script setup lang="ts">
-import { computed, inject, useTemplateRef } from "vue";
+import { inject, useTemplateRef } from "vue";
 import injectionKeys from "@/injectionKeys";
 import chroma from "chroma-js";
 
@@ -108,22 +107,8 @@ const COLOR_STEPS = [
 ];
 const rootEl = useTemplateRef("rootEl");
 const fields = inject(injectionKeys.evaluatedFields);
-const componentId = inject(injectionKeys.componentId);
-const wf = inject(injectionKeys.core);
 const isBeingEdited = inject(injectionKeys.isBeingEdited);
 
-const { isLinked: hasLinkedBlueprint } = useComponentLinkedBlueprints(
-	wf,
-	componentId,
-	"wf-tag-click",
-);
-
-const isClickable = computed(() => {
-	if (hasLinkedBlueprint.value) return true;
-	const component = wf.getComponentById(componentId);
-	return typeof component.handlers?.["wf-tag-click"] !== "undefined";
-});
-
 function generateColor(s: string | number) {
 	if (!fields.rotateHue.value) {
 		return fields.referenceColor.value;
@@ -188,7 +173,7 @@ function handleTagClick(tagId: string | number) {
 	display: flex;
 	align-items: center;
 	gap: 4px;
-	cursor: v-bind("isClickable ? 'pointer' : 'auto'");
+	cursor: pointer;
 	overflow: hidden;
 }
 .CoreTags__tag span {