Merge pull request #1113 from writer/fix-AB-272-writer-tool-calling-issues

fix: improve WriterToolCalling block error handling and AI behavior

Author: mmikita95

src/writer/blocks/writertoolcalling.py

@@ -1,9 +1,13 @@
+import textwrap
+from datetime import date
+
 from writer.abstract import register_abstract_template
 from writer.blocks.base_block import WriterBlock
 from writer.ss_types import AbstractTemplate
 
 DEFAULT_MODEL = "palmyra-x5"
 
+
 class WriterToolCalling(WriterBlock):
     @classmethod
     def register(cls, type: str):
@@ -17,16 +21,17 @@ def register(cls, type: str):
                     "description": "Connects the Agent to external tools to complete tasks it cannot handle directly.",
                     "category": "Writer",
                     "fields": {
-                        "prompt": {"name": "Prompt", "type": "Text", "control": "Textarea", "desc": "The task that needs to be carried out."},
-                        "modelId": {
-                            "name": "Model",
-                            "type": "Model Id",
-                            "default": DEFAULT_MODEL
+                        "prompt": {
+                            "name": "Prompt",
+                            "type": "Text",
+                            "control": "Textarea",
+                            "desc": "The task that needs to be carried out.",
                         },
+                        "modelId": {"name": "Model", "type": "Model Id", "default": DEFAULT_MODEL},
                         "maxIterations": {
                             "name": "Max iterations",
                             "type": "Number",
-                            "default": 10
+                            "default": 10,
                         },
                         "tools": {
                             "name": "Tools",
@@ -63,27 +68,35 @@ def _make_callable(self, tool_name: str):
 
         def callable(**args):
             expanded_execution_environment = self.execution_environment | args
-            return_value = repr(
-                self.runner.run_branch(
-                    self.component.id,
-                    f"tools_{tool_name}",
-                    expanded_execution_environment,
-                    f"Blueprint branch execution (tool {tool_name})",
-                )
+            raw_return_value = self.runner.run_branch(
+                self.component.id,
+                f"tools_{tool_name}",
+                expanded_execution_environment,
+                f"Blueprint branch execution (tool {tool_name})",
             )
-            if return_value is None:
+
+            if raw_return_value is None:
                 self.outcome = "error"
                 raise ValueError(
                     f'No value has been returned for the outcome branch "{tool_name}". Use the block "Return value" to specify one.'
                 )
-            self.execution_environment.get("trace").append(
-                {
-                    "type": "functionCall",
-                    "time": time.time(),
-                    "name": tool_name,
-                    "parameters": args,
-                }
-            )
+
+            transformed_result = self._project_common_tools_result(raw_return_value)
+            if transformed_result is None:
+                # Fallback avoids returning the literal string "None"
+                transformed_result = raw_return_value
+            return_value = repr(transformed_result)
+
+            trace = self.execution_environment.get("trace")
+            if trace is not None:
+                trace.append(
+                    {
+                        "type": "functionCall",
+                        "time": time.time(),
+                        "name": tool_name,
+                        "parameters": args,
+                    }
+                )
             return return_value
 
         return callable
@@ -123,15 +136,13 @@ def reasoning_callable(**kwargs):
             action = kwargs.get("action")
             status = kwargs.get("status")
 
-            self.execution_environment.get("trace").append({
-                "type": "reasoning",
-                "time": time.time(),
-                "thought": thought,
-                "action": action
-            })
+            trace = self.execution_environment.get("trace")
+            if trace is not None:
+                trace.append(
+                    {"type": "reasoning", "time": time.time(), "thought": thought, "action": action}
+                )
             if status == "DONE":
                 self.is_complete = True
-                
 
         reasoning_tool = {
             "type": "function",
@@ -149,8 +160,8 @@ def reasoning_callable(**kwargs):
                 },
                 "status": {
                     "type": "string",
-                    "description": "Set to DONE if you consider the task complete. Set to INCOMPLETE if you wish to keep iterating."
-                }
+                    "description": "Set to DONE if you consider the task complete. Set to INCOMPLETE if you wish to keep iterating.",
+                },
             },
         }
 
@@ -159,31 +170,36 @@ def reasoning_callable(**kwargs):
         return tools
 
     def _get_react_prompt(self, base_prompt: str):
-        return f"""
-        You're a ReAct agent.
-        Disclose your reasoning using the provided function.
-        
-        Task: {base_prompt}
-        """
-
+        return textwrap.dedent(f"""
+            You're a ReAct agent. Your knowledge cut-off date is 2024, but today is {str(date.today())}.
+            Disclose your reasoning using "disclose_reasoning" function.
+            
+            Task: {base_prompt.strip()}
+        """).strip()
+
+    def _project_common_tools_result(self, tool_result):
+        # Handle common HTTP-like shapes safely; pass through other types.
+        if isinstance(tool_result, dict):
+            if tool_result.get("request") and "body" in tool_result:
+                return tool_result["body"]
+        return tool_result
 
     def run(self):
         import writer.ai
+
         self.is_complete = False
 
         try:
             prompt = self._get_field("prompt")
             model_id = self._get_field("modelId", False, default_field_value=DEFAULT_MODEL)
-            max_iterations = int(self._get_field("maxIterations", False, "10"))
+            max_iterations = max(1, int(self._get_field("maxIterations", False, "10")))
             conversation = writer.ai.Conversation()
             tools = self._get_tools()
 
+            conversation += {"role": "user", "content": self._get_react_prompt(prompt)}
+
             for i in range(max_iterations):
-                conversation += {
-                    "role": "user",
-                    "content": self._get_react_prompt(prompt)
-                }
-                config = {"model": model_id}
+                config = {"model": model_id, "temperature": 0.1}
                 msg = conversation.complete(tools=tools, config=config)
                 conversation += msg
                 if self.is_complete: