Skip to content

Commit 7b22dd0

Browse files
author
Steve Thompson
committed
Changes made to package-lock.json. Redundant copies of dependencies are no longer downloaded.
Downloaded node_modules now seem to be as small as possible. Trying to speed up instantiation of PublicArray by making PublicArray.ts no longer import as many dependencies.
1 parent 1a2607f commit 7b22dd0

File tree

9 files changed

+186
-80
lines changed

9 files changed

+186
-80
lines changed

‎dist/index.d.ts‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,6 @@
1-
export declare function getPublicArray(array?: any[]): any;
1+
import { PublicArray } from './privy/PublicArray';
2+
3+
4+
// This must be used to instantiate PublicArray:
5+
6+
export declare function getPublicArray(array?: any[]): PublicArray;

‎dist/index.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ di_factory_1.DIFactory.register({
1818
public_array_remover_1.PublicArrayRemover, public_array_replacer_1.PublicArrayReplacer, public_array_sorter_1.PublicArraySorter
1919
]
2020
});
21+
// This must be used to instantiate PublicArray:
2122
function getPublicArray(array) {
2223
if (array === void 0) { array = []; }
2324
return di_factory_1.DIFactory.getInstance(PublicArray_1.PublicArray, [array]);

‎dist/privy/PublicArray.js‎

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,14 @@ var array_append_prepend_1 = require("@writetome51/array-append-prepend");
1717
var set_array_1 = require("@writetome51/set-array");
1818
var di_factory_1 = require("@writetome51/di-factory");
1919
var public_array_content_1 = require("@writetome51/public-array-content");
20+
// import { PublicArrayRemover } from '@writetome51/public-array-remover';
21+
// import { PublicArrayGetter } from '@writetome51/public-array-getter';
22+
// import { PublicArrayInserter } from '@writetome51/public-array-inserter';
23+
// import { PublicArraySorter } from '@writetome51/public-array-sorter';
24+
// import { PublicArrayReplacer } from '@writetome51/public-array-replacer';
25+
// import { PublicArrayGetterConverter } from '@writetome51/public-array-getter-converter';
26+
// import { PublicArrayGetterRemover } from '@writetome51/public-array-getter-remover';
27+
// import { PublicArrayFilter } from '@writetome51/public-array-filter';
2028
/**************
2129
This class is called PublicArray because an array is contained inside it,
2230
in a public property: 'data'
@@ -33,9 +41,26 @@ var public_array_content_1 = require("@writetome51/public-array-content");
3341
*************/
3442
var PublicArray = /** @class */ (function (_super) {
3543
__extends(PublicArray, _super);
44+
//Public Properties:
45+
// readonly copy: PublicArray (an independent copy of this instance).
46+
// readonly filter: PublicArrayFilter;
47+
// readonly getConverted: PublicArrayGetterConverter;
48+
// readonly get: PublicArrayGetter;
49+
// readonly getAndRemove: PublicArrayGetterRemover;
50+
// readonly insert: PublicArrayInserter;
51+
// readonly remove: PublicArrayRemover;
52+
// readonly replace: PublicArrayReplacer;
53+
// readonly sort: PublicArraySorter;
3654
function PublicArray(
3755
// begin injected dependencies...
38-
_filter, _getConverted, _get, _getAndRemove, _insert, _remove, _replace, _sort,
56+
_filter, //: PublicArrayFilter,
57+
_getConverted, //: PublicArrayGetterConverter,
58+
_get, //: PublicArrayGetter,
59+
_getAndRemove, //: PublicArrayGetterRemover,
60+
_insert, //: PublicArrayInserter,
61+
_remove, //: PublicArrayRemover,
62+
_replace, //: PublicArrayReplacer,
63+
_sort, //: PublicArraySorter,
3964
// ... end injected dependencies
4065
data // the actual array, represented by inherited property this.data
4166
) {

‎dist/tests.js‎

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,21 @@
11
"use strict";
22
Object.defineProperty(exports, "__esModule", { value: true });
33
var index_1 = require("./index");
4+
var arrays_match_1 = require("@writetome51/arrays-match");
45
var arr = index_1.getPublicArray([1, 2, 3, 4, 5, 6, 7, 8, 9]);
6+
// Test 1: getPublicArray() must return instance of PublicArray:
7+
if (arr.className && arr.className === 'PublicArray')
8+
console.log('test 1 passed');
9+
else
10+
console.log('test 1 FAILED');
11+
// Test 1A: the instance must contain the array passed into getPublicArray():
12+
if (arrays_match_1.arraysMatch(arr.data, [1, 2, 3, 4, 5, 6, 7, 8, 9]))
13+
console.log('test 1A passed');
14+
else
15+
console.log('test 1A FAILED');
516
console.log(arr.remove
617
.byIndexes([0, 2, 4, 6])
718
.data); // [2, 4, 6, 8, 9]
8-
arr.replace.each(function (value) { return (value / 3); });
9-
console.log(arr.data);
10-
console.log(arr.remove.between(1).data); // [2, 9]
11-
var arrCopy = arr.copy;
12-
arr.data = [1, 2];
13-
console.log(arrCopy.data); // [2, 9]
14-
console.log(arr.data); // [1, 2]
1519
/****************
1620
1721

‎lib/index.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ DIFactory.register(
2222
);
2323

2424

25+
// This must be used to instantiate PublicArray:
26+
2527
export function getPublicArray(array = []) {
2628
return DIFactory.getInstance(PublicArray, [array]);
2729
}

‎lib/privy/PublicArray.ts‎

Lines changed: 26 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
import { append, prepend } from '@writetome51/array-append-prepend';
22
import { setArray } from '@writetome51/set-array';
33
import { DIFactory } from '@writetome51/di-factory';
4-
import { PublicArrayRemover } from '@writetome51/public-array-remover';
54
import { PublicArrayContent } from '@writetome51/public-array-content';
6-
import { PublicArrayGetter } from '@writetome51/public-array-getter';
7-
import { PublicArrayInserter } from '@writetome51/public-array-inserter';
8-
import { PublicArraySorter } from '@writetome51/public-array-sorter';
9-
import { PublicArrayReplacer } from '@writetome51/public-array-replacer';
10-
import { PublicArrayGetterConverter } from '@writetome51/public-array-getter-converter';
11-
import { PublicArrayGetterRemover } from '@writetome51/public-array-getter-remover';
12-
import { PublicArrayFilter } from '@writetome51/public-array-filter';
5+
// import { PublicArrayRemover } from '@writetome51/public-array-remover';
6+
// import { PublicArrayGetter } from '@writetome51/public-array-getter';
7+
// import { PublicArrayInserter } from '@writetome51/public-array-inserter';
8+
// import { PublicArraySorter } from '@writetome51/public-array-sorter';
9+
// import { PublicArrayReplacer } from '@writetome51/public-array-replacer';
10+
// import { PublicArrayGetterConverter } from '@writetome51/public-array-getter-converter';
11+
// import { PublicArrayGetterRemover } from '@writetome51/public-array-getter-remover';
12+
// import { PublicArrayFilter } from '@writetome51/public-array-filter';
1313

1414

1515
/**************
@@ -31,30 +31,29 @@ import { PublicArrayFilter } from '@writetome51/public-array-filter';
3131
export class PublicArray extends PublicArrayContent {
3232

3333

34-
//Public Properties:
35-
36-
//readonly copy: PublicArray; // independent copy of this instance.
37-
readonly filter: PublicArrayFilter;
38-
readonly getConverted: PublicArrayGetterConverter;
39-
readonly get: PublicArrayGetter;
40-
readonly getAndRemove: PublicArrayGetterRemover;
41-
readonly insert: PublicArrayInserter;
42-
readonly remove: PublicArrayRemover;
43-
readonly replace: PublicArrayReplacer;
44-
readonly sort: PublicArraySorter;
34+
//Public Properties:
4535

36+
// readonly copy: PublicArray (an independent copy of this instance).
37+
// readonly filter: PublicArrayFilter;
38+
// readonly getConverted: PublicArrayGetterConverter;
39+
// readonly get: PublicArrayGetter;
40+
// readonly getAndRemove: PublicArrayGetterRemover;
41+
// readonly insert: PublicArrayInserter;
42+
// readonly remove: PublicArrayRemover;
43+
// readonly replace: PublicArrayReplacer;
44+
// readonly sort: PublicArraySorter;
4645

4746

4847
constructor(
4948
// begin injected dependencies...
50-
private _filter: PublicArrayFilter,
51-
private _getConverted: PublicArrayGetterConverter,
52-
private _get: PublicArrayGetter,
53-
private _getAndRemove: PublicArrayGetterRemover,
54-
private _insert: PublicArrayInserter,
55-
private _remove: PublicArrayRemover,
56-
private _replace: PublicArrayReplacer,
57-
private _sort: PublicArraySorter,
49+
private _filter, //: PublicArrayFilter,
50+
private _getConverted, //: PublicArrayGetterConverter,
51+
private _get, //: PublicArrayGetter,
52+
private _getAndRemove, //: PublicArrayGetterRemover,
53+
private _insert, //: PublicArrayInserter,
54+
private _remove, //: PublicArrayRemover,
55+
private _replace, //: PublicArrayReplacer,
56+
private _sort, //: PublicArraySorter,
5857
// ... end injected dependencies
5958

6059
data = [] // the actual array, represented by inherited property this.data

‎lib/tests.ts‎

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,24 @@
11
import { getPublicArray } from './index';
2+
import { arraysMatch } from '@writetome51/arrays-match';
23

34

45
let arr = getPublicArray([1, 2, 3, 4, 5, 6, 7, 8, 9]);
6+
7+
// Test 1: getPublicArray() must return instance of PublicArray:
8+
if (arr.className && arr.className === 'PublicArray') console.log('test 1 passed');
9+
else console.log('test 1 FAILED');
10+
11+
// Test 1A: the instance must contain the array passed into getPublicArray():
12+
if (arraysMatch(arr.data, [1, 2, 3, 4, 5, 6, 7, 8, 9])) console.log('test 1A passed');
13+
else console.log('test 1A FAILED');
14+
15+
516
console.log(
617
arr.remove
718
.byIndexes([0, 2, 4, 6])
819
.data
920
);// [2, 4, 6, 8, 9]
1021

11-
arr.replace.each((value) => (value / 3));
12-
console.log(arr.data);
13-
console.log(arr.remove.between(1).data); // [2, 9]
14-
let arrCopy = arr.copy;
15-
arr.data = [1, 2];
16-
console.log(arrCopy.data); // [2, 9]
17-
console.log(arr.data);// [1, 2]
1822

1923
/****************
2024

‎package-lock.json‎

Lines changed: 101 additions & 36 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)