Skip to content

Commit cd30e37

Browse files
EnricoMitiangolo
andauthored
Make pagination work with GraphQL response data (PyGithub#3047)
This allows to create paginated lists of `GithubObject`s from data retrieved from the GraphQL API. --------- Co-authored-by: Sebastián Ramírez <[email protected]>
1 parent 2722225 commit cd30e37

File tree

10 files changed

+217
-91
lines changed

10 files changed

+217
-91
lines changed

github/Commit.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,11 +125,11 @@ def files(self) -> PaginatedList[File]:
125125
self._requester,
126126
self.url,
127127
{},
128-
None,
129-
"files",
130-
"total_files",
131-
self.raw_data,
132-
self.raw_headers,
128+
headers=None,
129+
list_item="files",
130+
total_count_item="total_files",
131+
firstData=self.raw_data,
132+
firstHeaders=self.raw_headers,
133133
)
134134

135135
@property

github/Comparison.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,11 @@ def commits(self) -> PaginatedList[github.Commit.Commit]:
9191
self._requester,
9292
self.url,
9393
{},
94-
None,
95-
"commits",
96-
"total_commits",
97-
self.raw_data,
98-
self.raw_headers,
94+
headers=None,
95+
list_item="commits",
96+
total_count_item="total_commits",
97+
firstData=self.raw_data,
98+
firstHeaders=self.raw_headers,
9999
)
100100

101101
@property

github/EnterpriseConsumedLicenses.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ def get_users(self) -> PaginatedList[NamedEnterpriseUser]:
9191
self._requester,
9292
self.url,
9393
url_parameters,
94-
None,
95-
"users",
94+
headers=None,
95+
list_item="users",
9696
firstData=self.raw_data,
9797
firstHeaders=self.raw_headers,
9898
)

github/Organization.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -993,7 +993,7 @@ def get_projects(self, state: Opt[str] = NotSet) -> PaginatedList[Project]:
993993
self._requester,
994994
f"{self.url}/projects",
995995
url_parameters,
996-
{"Accept": Consts.mediaTypeProjectsPreview},
996+
headers={"Accept": Consts.mediaTypeProjectsPreview},
997997
)
998998

999999
def get_public_members(self) -> PaginatedList[NamedUser]:
@@ -1285,7 +1285,7 @@ def get_installations(self) -> PaginatedList[Installation]:
12851285
self._requester,
12861286
f"{self.url}/installations",
12871287
None,
1288-
None,
1288+
headers=None,
12891289
list_item="installations",
12901290
)
12911291

0 commit comments

Comments
 (0)