Fix ForEachLineInFile to not lose the last line if it doesn't end with a LF

Author: stefanhaller

pkg/integration/tests/conflicts/resolve_without_trailing_lf.go

@@ -52,9 +52,6 @@ var ResolveWithoutTrailingLf = NewIntegrationTest(NewIntegrationTestArgs{
 				Contains("M  file").IsSelected(),
 			)
 
-		/* EXPECTED:
 		t.Views().Main().Content(Contains("-a1\n+a2\n").DoesNotContain("-no eol"))
-		ACTUAL: */
-		t.Views().Main().Content(Contains("-a1\n+a2\n").Contains("-no eol"))
 	},
 })

pkg/utils/io.go

@@ -21,8 +21,8 @@ func ForEachLineInFile(path string, f func(string, int)) error {
 func forEachLineInStream(reader io.Reader, f func(string, int)) {
 	bufferedReader := bufio.NewReader(reader)
 	for i := 0; true; i++ {
-		line, err := bufferedReader.ReadString('\n')
-		if err != nil {
+		line, _ := bufferedReader.ReadString('\n')
+		if len(line) == 0 {
 			break
 		}
 		f(line, i)

pkg/utils/io_test.go

@@ -26,10 +26,7 @@ func Test_forEachLineInStream(t *testing.T) {
 		{
 			name:          "single line without line feed",
 			input:         "abc",
-			/* EXPECTED:
 			expectedLines: []string{"abc"},
-			ACTUAL: */
-			expectedLines: []string{},
 		},
 		{
 			name:          "multiple lines",
@@ -44,10 +41,7 @@ func Test_forEachLineInStream(t *testing.T) {
 		{
 			name:          "multiple lines without linefeed at end of file",
 			input:         "abc\ndef\nghi",
-			/* EXPECTED:
 			expectedLines: []string{"abc\n", "def\n", "ghi"},
-			ACTUAL: */
-			expectedLines: []string{"abc\n", "def\n"},
 		},
 	}