Fixed memory leak in unit-tests (deepcode found it)

Author: sea5kg

unit-tests.wsjcpp/src/unit_test_parsing_request_params.cpp

@@ -124,6 +124,7 @@ void UnitTestParsingRequestParams::executeTest() {
         compare("checkInputParams0 id", sId, "id1");
         std::string sMethod = jsonResponse["method"];
         compare("checkInputParams0 method", sMethod, "game_create");
+        delete pRequest;
     }
 
     // checkInputParams - paramer datatype string
@@ -155,6 +156,7 @@ void UnitTestParsingRequestParams::executeTest() {
         compare("checkInputParams1 id", sId, "id1");
         std::string sMethod = jsonResponse["method"];
         compare("checkInputParams1 method", sMethod, "game_create");
+        delete pRequest;
     }
 
     // checkInputParams - parameter data type int
@@ -186,6 +188,7 @@ void UnitTestParsingRequestParams::executeTest() {
         compare("checkInputParams2 id", sId, "id1");
         std::string sMethod = jsonResponse["method"];
         compare("checkInputParams2 method", sMethod, "game_create");
+        delete pRequest;
     }
 
     // checkInputParams - parameter data type boolean
@@ -223,6 +226,7 @@ void UnitTestParsingRequestParams::executeTest() {
         compare("checkInputParams3 id", sId, "id1");
         std::string sMethod = jsonResponse["method"];
         compare("checkInputParams3 method", sMethod, "game_create");
+        delete pRequest;
     }
 
     // checkInputParams - parameter data type json
@@ -259,6 +263,7 @@ void UnitTestParsingRequestParams::executeTest() {
         compare("checkInputParams4 id", sId, "id1");
         std::string sMethod = jsonResponse["method"];
         compare("checkInputParams4 method", sMethod, "game_create");
+        delete pRequest;
     }
 
     // checkInputParams - extra field
@@ -297,6 +302,7 @@ void UnitTestParsingRequestParams::executeTest() {
         compare("checkInputParams5 id", sId, "id1");
         std::string sMethod = jsonResponse["method"];
         compare("checkInputParams5 method", sMethod, "game_create");
+        delete pRequest;
     }
 
     // checkInputParams - string validator
@@ -336,6 +342,7 @@ void UnitTestParsingRequestParams::executeTest() {
         compare("checkInputParams6 id", sId, "id1");
         std::string sMethod = jsonResponse["method"];
         compare("checkInputParams6 method", sMethod, "game_create");
+        delete pRequest;
     }
 
     // checkInputParams - int validator
@@ -375,6 +382,7 @@ void UnitTestParsingRequestParams::executeTest() {
         compare("checkInputParams7 id", sId, "id1");
         std::string sMethod = jsonResponse["method"];
         compare("checkInputParams7 method", sMethod, "game_create");
+        delete pRequest;
     }
 
     // checkInputParams - json validator
@@ -414,7 +422,12 @@ void UnitTestParsingRequestParams::executeTest() {
         compare("checkInputParams8 id", sId, "id1");
         std::string sMethod = jsonResponse["method"];
         compare("checkInputParams8 method", sMethod, "game_create");
+        delete pRequest;
     }
+
+    delete pHandlergameCreate;
+    delete pWebSocketServer;
+    delete pFakeClient;
 }
 
 // ---------------------------------------------------------------------

unit-tests.wsjcpp/src/unit_test_request_parse_income_data.cpp

@@ -39,6 +39,7 @@ void UnitTestRequestParseIncomeData::executeTest() {
         compareS("parseIncomeData empty. id", sId, "unknown_id");
         std::string sMethod = jsonResponse["method"];
         compareS("parseIncomeData empty. method", sMethod, "unknown_method");
+        delete pRequest;
     }
 
     // missing 'id' in request
@@ -60,6 +61,7 @@ void UnitTestRequestParseIncomeData::executeTest() {
         compareS("parseIncomeData missing id. id", sId, "unknown_id");
         std::string sMethod = jsonResponse["method"];
         compareS("parseIncomeData missing id. method", sMethod, "game_create");
+        delete pRequest;
     }
 
     // missing 'method' in request
@@ -82,6 +84,7 @@ void UnitTestRequestParseIncomeData::executeTest() {
         compareS("parseIncomeData missing method. id", sId, "id1");
         std::string sMethod = jsonResponse["method"];
         compareS("parseIncomeData missing method. method", sMethod, "unknown_method");
+        delete pRequest;
     }
 
     // missing 'jsonrpc' in request
@@ -104,6 +107,7 @@ void UnitTestRequestParseIncomeData::executeTest() {
         compareS("parseIncomeData missing jsonrpc. id", sId, "id1");
         std::string sMethod = jsonResponse["method"];
         compareS("parseIncomeData missing jsonrpc. method", sMethod, "game_create");
+        delete pRequest;
     }
 
     // field 'jsonrpc' is non string in request
@@ -127,6 +131,7 @@ void UnitTestRequestParseIncomeData::executeTest() {
         compareS("parseIncomeData jsonrpc is non string. id", sId, "id1");
         std::string sMethod = jsonResponse["method"];
         compareS("parseIncomeData jsonrpc is non string. method", sMethod, "game_create");
+        delete pRequest;
     }
 
     // field 'jsonrpc' is no "2.0" in request
@@ -150,6 +155,7 @@ void UnitTestRequestParseIncomeData::executeTest() {
         compareS("parseIncomeData jsonrpc is no 2.0. id", sId, "id1");
         std::string sMethod = jsonResponse["method"];
         compareS("parseIncomeData jsonrpc is no 2.0. method", sMethod, "game_create");
+        delete pRequest;
     }
 
     // field 'params' wrong
@@ -174,6 +180,7 @@ void UnitTestRequestParseIncomeData::executeTest() {
         compareS("parseIncomeData field params wrong. id", sId, "id1");
         std::string sMethod = jsonResponse["method"];
         compareS("parseIncomeData field params wrong. method", sMethod, "game_create");
+        delete pRequest;
     }
 
     // success parsing
@@ -189,7 +196,11 @@ void UnitTestRequestParseIncomeData::executeTest() {
         compareB("parseIncomeData success parsing", pRequest->parseIncomeData(sRequest), true);
         std::string sResponse = pFakeClient->getLastTextMessage();
         compareS("parseIncomeData success parsing. error must be empty", sResponse, "");
+        delete pRequest;
     }
+
+    delete pWebSocketServer;
+    delete pFakeClient;
 }
 
 // ---------------------------------------------------------------------